Bug fixes & cleanup #320
Open
Bug fixes & cleanup #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including qbsql_ fields in each table caused the qb_salesreceipt table to exceed MySQL table size limits. The simplest solution might have been to use latin1 instead of utf8mb4 encoding, but that wasn't considered ideal. Other workarounds would have required changes to the table structure, such as the use of TEXT or JSON columns. For reference, see https://mariadb.com/kb/en/troubleshooting-row-size-too-large-errors-with-innodb/ Redundant code was also simplified, and a few utility functions were added to the SQL Driver class.
Note that the changes in Callbacks.php didn't solve the problem and may not be necessary, but should be fine anyway.
superdav42
reviewed
May 16, 2024
| $id = $Driver->escape($existing['TxnID']); | ||
| $sql = "SELECT $pKey FROM $table WHERE ReceivePayment_TxnID = '$id'"; | ||
| $ids = $Driver->get_col($sql, $db_errnum, $db_errmsg); | ||
| $Driver->query("UPDATE quickbooks_qbsql SET qbsql_to_skip = 1 WHERE $pKey IN (".implode(',',$ids).")", |
There was a problem hiding this comment.
This BC break since quickbooks_qbsql could have a different name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues found when running the code in PHP 8 (only for scripts we've used):
Improves code by refactoring, especially reducing redundant wrapper XML.
Automatic debug logging when $log_level = QUICKBOOKS_LOG_DEVELOP.
The change in README.md should not be pulled, but I don't know how to exclude it.