Fix for php 8.1 compatibility #330
Conversation
QuickBooks/Driver/Sql/Mysqli.php
Outdated
| @@ -436,7 +436,7 @@ protected function _escape($str) | |||
| $str = ''; | |||
| } | |||
|
|
|||
| return $this->_conn->real_escape_string($str); | |||
| return $this->_conn->real_escape_string($str ?? ''); | |||
There was a problem hiding this comment.
NOTE: Please do this place and similar places in this PR, where ?? is used.
Usage of the null coalescing operator (??) on the PHP < 7.0 would result in a syntax error.
Please adjust the code to also work on PHP 5.x (according to composer.json this library supports PHP 5.x).
For this particular place maybe it's better to return NULL, when $str === null, but since there are no automated tests, this might break things :(
There was a problem hiding this comment.
I used isset() ? : instead...
|
Please also remove |
Done. |
|
Looks perfect to me. @xtremevision , Have you tested these changes in a production environment (e.g. in a project that runs on PHP 8.1+, where this library is used)? |
|
Tbh I can't remember. A lot of time has passed since I placed this PR. I can't remember if I used it and/or where. I'll check. |
QuickBooks/XML.php
Outdated
| @@ -433,8 +433,8 @@ static public function decode($str, $for_qbxml = true) | |||
| '"' => '"', | |||
| '&' => '&', // Make sure that this is *the last* transformation to run, otherwise we end up double-un-encoding things | |||
| ); | |||
|
|
|||
| return str_replace(array_keys($transform), array_values($transform), $str); | |||
|
|
|||
There was a problem hiding this comment.
This is the last change. Please remove this trailing space.
|
I hope that once this PR is merged. The library would be work on PHP 8.1+. For people using this library, that should be a big relief. If possible, consider switching to the official QuickBooks API client for PHP: https://github.com/intuit/QuickBooks-V3-PHP-SDK . |
|
Done. Removed trailing space. |
You've removed the wrong trailing space. There should be one empty file at the end of each file. I was talking about the empty line above the |
|
Sorry, try now. |
|
Great. Thank you @xtremevision . |
Many people probably would if this SDK supported QB Desktop. |
Fixed array notation curly brackets