Rename len() to count() to reflect its performance implication #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rust,
len()
(as a noun) is commonly used to refer to something which can be figured out in constant time, usually reading a field or so, while the function here apparently is not just reading some field, but instead iterating through the internal vector and add up the number of set bits. For non-constant time operations, it should be preferred to use a verb name to indicate that it may not be cheap. I think the convention is to usecount()
for this scenario.I also bumped the minor version as renaming a function is a breaking change. Let me know if you prefer keeping
len()
but having it deprecated so that we don't do breaking change for this.