Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add secrets field support for ControllerGetVolume Request #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jun 16, 2022

At present secrets are not part of this request and some
consumers need this field for its operation.: That said,
storage backends like Ceph Cluster require the access to be
achieved with the help of authentication. For such systems this
becomes a requirement to have secrets/credentials be part of
the request CO make for its further operations or fetching the state
from the backend cluster.

Additional note for reviewer:
Similar request was raised for NodeGetVolumeStats() here #
#371
which was not reached into consensus. One concern raised in similar request (#371)
is the explosion of secrets field in the spec for various RPC calls.
In turn this secret field requirement becoming a request for pretty
much all the RPC calls.

Signed-off-by: Humble Chirammal [email protected]
Signed-off-by: Prasanna Kumar Kalever [email protected]

csi.proto Outdated Show resolved Hide resolved
@humblec humblec force-pushed the controller-get-volume branch 2 times, most recently from f667a20 to 9b2faaa Compare June 16, 2022 09:50
At present secrets are not part of this request and some
consumers need this field for its operation.: That said,
storage backends like Ceph Cluster require the access to be
achieved with the help of authentication. For such systems this
becomes a requirement to have secrets/credentials be part of
the request CO make for its further operations or fetching the state
from the backend cluster.

Signed-off-by: Humble Chirammal <[email protected]>
@xing-yang
Copy link
Contributor

Do we also need a corresponding field in the PV?

@humblec
Copy link
Contributor Author

humblec commented Sep 21, 2022

Do we also need a corresponding field in the PV?

@xing-yang I was planning to have the PV/CO side ( implementation) details listed in Kube issue as the field and implementation require some thoughts as discussed in #371. Considering CSI spec support can be independent to the implementation of CO, thought of pulling this first.

@humblec
Copy link
Contributor Author

humblec commented Sep 22, 2022

Cc @jdef

@bswartz
Copy link
Contributor

bswartz commented Jan 18, 2023

I agree that we need to pass secrets down to ControllerGetVolume, but I'd prefer to do it in such a way that doesn't require COs to store ever more secrets (as I mentioned in #371). Is anyone working on a proposal to constrain secret handling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants