Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describe what if topology not match exactly #561

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Mar 11, 2024

What type of PR is this?

What this PR does / why we need it:

Describe what to expect when the accessible_topology of node and volume does not match exactly.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce an API-breaking change?:

none

Copy link
Member

@jdef jdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this PR clarifies the original intent of topology matching, thanks!

I'm undecided on the risk factor, and have limited brain cycles to spend here at the moment. Curious if anyone else in the community is concerned about potential breakage this language change might imply.

spec.md Outdated Show resolved Hide resolved
spec.md Outdated Show resolved Hide resolved
spec.md Outdated
@@ -1050,6 +1050,11 @@ message Volume {
// COs MAY use this information along with the topology information
// returned by NodeGetInfo to ensure that a given volume is accessible
// from a given node when scheduling workloads.
// The volume is accessible from all locations in the
// specified topology.
// The volume is accessible from a node if the volume's
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... from a node if at least one of the volume's accessible topologies is a superset of ...

because a volume can have multiple accessible topologies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added "union of", since I am already using the term of set theory.

spec.md Outdated
// The node can access some of the locations in the
// specified topology.
// The node can access a volume if the node's accessible_topology
// is a subset of the volume's accessible_topology.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. is a subset of at least one of the volume's accessible topologies.

Describe what to expect when the accessible_topology of node and volume does
not match exactly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants