Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: symlink-safer tinygo docker builds. #136

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

klihub
Copy link
Member

@klihub klihub commented Jan 27, 2025

Don't let symlinks on $(PWD) break dockerized tinygo builds of the sample WASM plugin so easily.

Don't let symlinks on $(PWD) break dockerized tinygo builds
of the sample WASM plugin so easily.

Signed-off-by: Krisztian Litkey <[email protected]>
@klihub klihub requested a review from fuweid January 27, 2025 09:05
@klihub klihub requested a review from mikebrow February 3, 2025 11:15
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit a8b717f into containerd:main Feb 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants