-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New VMs: include netavark in prior-fedora #325
Conversation
dfd2e57
to
2eeccea
Compare
Cirrus CI build successful. Found built image names and IDs:
|
Compared to #324
|
I guess we'll find out soon enough, but the |
Yep, no aardvark. I'm guessing this is fallout from the weekend netavark SNAFU. Punting until tomorrow. |
Looks like aardvark needs to be included, trips in containers/podman#21366. Weird because it doesn't trip in our current f39, so it has to be installed there right now? |
See group email. This is (I'm 99% sure) fallout from this weekend's netavark disaster. I just don't understand why that happened. |
Whew! Okay I think they're all closed and linked back to this PR. I can't find a Renovate PR for the podman repo. Was the v20240125 image put in place manually there? I hope you don't feel bad Ed, this could have happened to anybody. |
containers/podman#21366 was my PR for the 0125 image, but since it was stalled I decided to repush it with the new 0129 images from today. Then kablooey. |
Gotca, so it sounds like there is a risk Renovate could still open a 0125 PR for podman. I've seen it "sleep" on update PRs before, and I also don't have the (deliberately) set update schedules all memorized 🤔 I'm now completely and thoroughly trigger shy when it comes to sending any warning messages to the group. On the off-chance I happen to use some unapproved word. If a "podman-update PR: do not merge" warning mail is urgent and important, somebody else can write it. |
2eeccea
to
8757b3e
Compare
cache_images/fedora_packaging.sh
Outdated
@@ -37,7 +37,11 @@ msg "Updating/Installing repos and packages for $OS_REL_VER" | |||
|
|||
bigto ooe.sh $SUDO dnf update -y | |||
|
|||
# netavark crisis of 2024-01-27 weekend | |||
timebomb 20240210 "Please remove aardvark-dns from INSTALL_PACKAGES; netavark should Require it" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cirrus CI build successful. Found built image names and IDs:
|
I found Renovate's podman update task queued due to rate-limiting, in the dependency dashboard. So indeed it was on a hair-trigger as I feared. Anyhoo, I'm glad this didn't happen in the middle of the night. I tripped it manually just now, and when the PR shows up I'll close it to prevent any accidents. |
Comparing against last week's build
|
Thanks Chris. It's not a big deal if it had merged, but it wouldn't have merged anyway because CI would've failed. |
Oh whew! Thanks for the extra perspective. It appeared like a dooms-day thing to me. Glad it's not. |
175c10b
to
843f9ef
Compare
Netavark-1.9 is gone from rawhide; I cannot install it. Netavark-1.10 is broken. A fix is in progress but then it'll have to get built and bodhi'ed etc etc. |
CNI is deprecated, and will no longer be tested in CI (Podman PR 21410). We've been force-removing netavark from prior-fedora. Remove this special case so now all fedorae have netavark. Signed-off-by: Ed Santiago <[email protected]>
843f9ef
to
8c0332d
Compare
Cirrus CI build successful. Found built image names and IDs:
|
Sigh. Still broken netavark. No point in testing this in podman.
|
From containers/automation_images#325 Major change: netavark and aardvark are now included in prior-fedora, so CNI can be fully eliminated from CI (containers#21410) FIXME FIXME FIXME: skip two e2e tests, waiting for new netavark Signed-off-by: Ed Santiago <[email protected]>
@cevich PTAL when convenient, and merge if acceptable. TL;DR our lack of VMs is causing cascading blocks of important CI changes. Podman tests have passed: containers/podman#21366 I will open a new PR next week to try to bring in a working netavark. |
Thanks Ed. Do you have an opinion on if this version should be tagged? Or, should we maybe wait a few days at least maybe? |
No, absolutely do not tag. Netavark is broken. I will be spinning new VMs again next week. Thanks. |
CNI is deprecated, and will no longer be tested in CI (Podman
PR 21410).
We've been force-removing netavark from prior-fedora. Remove
this special case so now all fedorae have netavark.
Signed-off-by: Ed Santiago [email protected]