cli: add system-reinstall-bootc binary
#1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omertuc
force-pushed
the
reinstallcli
branch
2 times, most recently
from
88934de to
a645547
Compare
cgwalters
reviewed
Jan 27, 2025
omertuc
force-pushed
the
reinstallcli
branch
11 times, most recently
from
f6f60e7 to
30b8271
Compare
omertuc
force-pushed
the
reinstallcli
branch
5 times, most recently
from
a4d4e6f to
7498bdf
Compare
cgwalters
reviewed
Jan 30, 2025
germag
reviewed
Feb 3, 2025
omertuc
changed the title
bootc-reinstall binarysystem-reinstall-bootc binary
This was referenced Feb 5, 2025
cgwalters
approved these changes
Feb 5, 2025
| // The container needs to access the host's PID namespace to mount host directories | ||
| "--pid=host", | ||
| // Since https://github.com/containers/bootc/pull/919 this mount should not be needed, but | ||
| // some reason with e.g. quay.io/fedora/fedora-bootc:41 it is still needed. |
There was a problem hiding this comment.
We should try to root cause some of this. Let's pile onto #1053
omertuc
force-pushed
the
reinstallcli
branch
2 times, most recently
from
b9743fd to
241ea1f
Compare
|
EDIT: Done
|
Refactor the tracing initialization code into a utility function, so that it can be shared with future CLIs that we'll add. Signed-off-by: Omer Tuchfeld <[email protected]>
The CLI crate does not use clap directly, so it does not need to depend on it. It does use it indirectly, through the our lib crate Signed-off-by: Omer Tuchfeld <[email protected]>
No reason for it to be different than what we have in the root Cargo.toml Signed-off-by: Omer Tuchfeld <[email protected]>
# Background The current usage instructions for bootc involve a long podman invocation. # Issue It's hard to remember and type the long podman invocation, making the usage of bootc difficult for users. See https://issues.redhat.com/browse/BIFROST-610 and https://issues.redhat.com/browse/BIFROST-611 (Epic https://issues.redhat.com/browse/BIFROST-594) # Solution We want to make the usage of bootc easier by providing a new Fedora/RHEL subpackage that includes a new binary `system-reinstall-bootc`. This binary will simplify the usage of bootc by providing a simple command line interface (configured either through CLI flags or a configuration file) with an interactive prompt that allows users to reinstall the current system using bootc. The commandline will handle helping the user choose SSH keys / users, warn the user about the destructive nature of the operation, and eventually report issues they might run into in the various clouds (e.g. missing cloud agent on the target image) # Implementation Added new system-reinstall-bootc crate that outputs the new system-reinstall-bootc binary. This new crate depends on the existing utils crate. Refactored the tracing initialization from the bootc binary into the utils crate so that it can be reused by the new crate. The new CLI can either be configured through commandline flags or through a configuration file in a path set by the environment variable `BOOTC_REINSTALL_CONFIG`. The configuration file is a YAML file. # Limitations Only root SSH keys are supported. The multi user selection TUI is implemented, but if you choose anything other than root you will get an error. # TODO Missing docs, missing functionality. Everything is in alpha stage. User choice / SSH keys / prompt disabling should also eventually be supported to be configured through commandline arguments or the configuration file. Signed-off-by: Omer Tuchfeld <[email protected]>
Modified the bootc.spec file to generate a new subpackage which includes the new system-reinstall-bootc binary. # Try Try out instructions: ```bash # Make srpm cargo xtask package-srpm # Mock group sudo usermod -a -G mock $(whoami) newgrp mock # Build RPM for RHEL mock --rebuild -r rhel+epel-9-x86_64 --rebuild target/bootc-*.src.rpm ``` Then install the RPM (`/var/lib/mock/rhel+epel-9-x86_64/result/bootc-reinstall-2*.el9.x86_64.rpm`) on [a rhel9 gcp vm](https://console.cloud.google.com/compute/instanceTemplates/details/rhel9-dev-1?project=bifrost-devel&authuser=1&inv=1&invt=Abn-jg) instance template Signed-off-by: Omer Tuchfeld <[email protected]>
I also added a new label too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages