Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: enable pasta tests #5381

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Mar 5, 2024

What type of PR is this?

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind other

What this PR does / why we need it:

This should have been done a long time ago and this would have made clear that it did not work properly. However now that pasta is the default and we fixed all the remaining problems we can easily enable them.

How to verify it

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@edsantiago
Copy link
Member

LGTM. Cirrus VMs are c20240222t143004z-f39f38d13 built in containers/automation_images#329 (comment) which contain pasta 2024-02-20 everywhere. (Also contain the broken rawhide kernel, but AFAICT nothing in buildah CI uses rawhide)

@TomSweeneyRedHat
Copy link
Member

LGTM

@TomSweeneyRedHat
Copy link
Member

/lgtm
/hold # for happy tests

@Luap99
Copy link
Member Author

Luap99 commented Mar 12, 2024

@TomSweeneyRedHat Note, there was no conflict nor any real changes of causing other merge problems here. The rebase feature creates completely useless merge commits in the git log by default, ("Merge branch 'main' into pasta") is obviously not useful when reading the git log.

If you really want to make sure everything is up to date even when there is no need then please make sure to rebase the PR and not use a merge commit:
image

This should have been done a long time ago and this would have made
clear that it did not work properly. However now that pasta is the
default and we fixed all the remaining problems we can easily enable
them.

Signed-off-by: Paul Holzinger <[email protected]>
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

@Luap99, apologies for the merge hiccups. I just saw what looked to be a "You can' merge this unless you hit this big shiny button", and since it was late, I hit the shiny. I'll try to pay more attention going forward.

@TomSweeneyRedHat
Copy link
Member

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 77ce754 into containers:main Mar 13, 2024
36 checks passed
@Luap99 Luap99 deleted the pasta branch March 13, 2024 10:24
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants