systemd, cgroup: configure cgroups before joining them #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure the cpu rt and cpuset controllers before joining them. This avoids running (even temporarily) the workload on cpus it was not supposed to run on. Signed-off-by: Giuseppe Scrivano <[email protected]>
|
this should not be merged until @haircommander confirms it works |
|
this seems to not fix the issue @haircommander had but I think it is still correct to configure the cgroups before moving the process there, so we probably want it anyway. @flouthoc PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure the cpu rt and cpuset controllers before joining them. This avoids running (even temporarily) the workload on cpus it was not supposed to run on.