Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgroup: Show the absolute path to cgroup.controllers when a controller is not available #1639

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

aarontomlin
Copy link
Contributor

This patch will provide the absolute path to the cgroup.controllers file in the error message if the specified controller is not available. Hopefully this will help with troubleshooting efforts.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some inline comments, also please run make clang-format and amend the changes

src/libcrun/utils.c Outdated Show resolved Hide resolved
src/libcrun/cgroup-resources.c Outdated Show resolved Hide resolved
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks,

LGTM

src/libcrun/utils.c Outdated Show resolved Hide resolved
…r is not available

This patch will provide the absolute path to the cgroup.controllers file
in the error message if the specified controller is not available.
Hopefully this will help with troubleshooting efforts.

Signed-off-by: Aaron Tomlin <[email protected]>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 15, 2025

LGTM

@rhatdan rhatdan merged commit a646439 into containers:main Jan 15, 2025
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants