shellcheck corrections #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarboa
requested review from
ericcurtin,
rhatdan,
dougsland and
masneyb
as code owners
ericcurtin
reviewed
Nov 29, 2023
ericcurtin
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
I think this is ok, just a question, did we test this?
I worry about things like:
| "$decompressor" |
do they work like we intend, with the lack of CI in this project at present, we have to manually test every change until we get proper CI, that executes this stuff e2e.
|
Thanks for looking into this @Yarboa I think this is our first green PR! |
|
Moving to draft, |
shellcheck tests are broken fixing script based on shell check recommendations Signed-off-by: Yariv Rachmani <[email protected]>
|
@ericcurtin |
|
Thanks for testing, mergy mergy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shellcheck tests are broken
fixing script based on shell check recommendations
sample https://github.com/containers/initoverlayfs/actions/runs/6946556735