Adding tmt packit automation #28

Yarboa · 2023-11-30T17:19:50Z

Tests are run by packit through tmt in testsing-farm Adding integration plan and tier-0 test verifying
initoverlayfs setup

resolve #23

ericcurtin · 2023-11-30T17:24:57Z

This is really neat @Yarboa

dougsland · 2023-11-30T18:32:21Z

LGTM

ericcurtin · 2023-12-01T17:34:33Z

This should work after we merge this I think:

#30

we need PR number 30 anyway for unaccounted devices.

ericcurtin · 2023-12-01T21:28:56Z

I think a rebase should fix this @Yarboa

integration/plans/tier-0.fmf

.packit.yaml

lsm5 · 2023-12-04T13:43:37Z

LGTM as far as packit changes are concerned.

You might wanna also switch to autospec to get rid of the changelog burden in rpm spec (doesn't concern this PR).

mwperina

LGTM

mwperina · 2023-12-07T14:21:09Z

/packit test

packit-as-a-service · 2023-12-07T14:21:29Z

Account mwperina has no write access nor is author of PR!

Yarboa · 2023-12-07T14:32:20Z

LGTM

I suspect there is new issue with F39. checking manually
I will add f38 also, i verified it manually.
I thing it is the latest updates from eric.

Verified manually with 6.5.6-300.fc39.x86_64
public runch is down i think
https://status.testing-farm.io/affected/public-ranch/

I will try to trigger later

ericcurtin · 2023-12-07T17:46:20Z

On this @mwperina

"ccount mwperina has no write access nor is author of PR!"

I added you as a member with write access, I think you just have to accept.

mwperina · 2023-12-08T09:23:23Z

/packit test

packit-as-a-service · 2023-12-08T09:23:35Z

Account mwperina has no write access nor is author of PR!

mwperina · 2023-12-08T09:26:31Z

/packit test

mwperina · 2023-12-08T09:27:38Z

On this @mwperina

"ccount mwperina has no write access nor is author of PR!"

I added you as a member with write access, I think you just have to accept.

I probably missed some email, but I was able to find out the invite in my organizations and it works fine.
Thanks Eric.

Yarboa · 2023-12-08T19:22:23Z

There is an issue with reboot

            00:00:25 /integration/tests/boot-validation [1/1]
            00:00:25 errr /integration/tests/boot-validation (on default-0) (reboot timeout) [1/1]
        fail: Failed to pull workdir from the guest. This usually means that login as 'root' to the guest does not work

I will have to reserve AWS and debug

Yarboa · 2023-12-11T13:15:56Z

Ok i was running it manually on testing farm
https://artifacts.dev.testing-farm.io/a933c23c-ec8d-45b0-9002-cc75814415ae/
It seems to be TF issue, lets wait to this PR to pass all tests

Interesting with packit and generated rpms it is failing
so on AWS 0.98 is failing while 0.96 is passing.

https://pastebin.com/esSjVz9a

ericcurtin · 2023-12-13T16:30:48Z

If we rebase this it might just work @Yarboa

mwperina · 2023-12-14T08:53:40Z

I just noticed that RPMs are generated as they would be a stable release (initoverlayfs-0.98-1.el9.src.rpm) and not as a snapshot build (initoverlayfs-0.98-0.202312131810.gitefcc221.el9.src.rpm). That should be fixed, if we want to include those RPMs into some snaphot builds repo (for example under centos-automotive-sig group) and make them consumable for other testers

Yarboa · 2023-12-14T09:56:30Z

I just noticed that RPMs are generated as they would be a stable release (initoverlayfs-0.98-1.el9.src.rpm) and not as a snapshot build (initoverlayfs-0.98-0.202312131810.gitefcc221.el9.src.rpm). That should be fixed, if we want to include those RPMs into some snaphot builds repo (for example under centos-automotive-sig group) and make them consumable for other testers

@mwperina thanks
do you refer running to something like this ? build-scripts/version.sh

mwperina · 2023-12-14T10:15:39Z

I just noticed that RPMs are generated as they would be a stable release (initoverlayfs-0.98-1.el9.src.rpm) and not as a snapshot build (initoverlayfs-0.98-0.202312131810.gitefcc221.el9.src.rpm). That should be fixed, if we want to include those RPMs into some snaphot builds repo (for example under centos-automotive-sig group) and make them consumable for other testers

@mwperina thanks do you refer running to something like this ? build-scripts/version.sh

So BlueChi has that support, so if you want to inspire, please take a look at those files:

https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/build-rpm.sh
https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/build-srpm.sh

Above 2 files are not needed for packit, they are here for previous GH build/test integration and for local command line convenience.

Below files are required for packit integration:
https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-archive.sh
https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-spec.sh
https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/version.sh
https://github.com/eclipse-bluechi/bluechi/blob/main/.packit.yml#L20

But maybe it can be simplifed for initoverlayfs, which is much smaller project

Yarboa · 2023-12-14T10:19:30Z

I just noticed that RPMs are generated as they would be a stable release (initoverlayfs-0.98-1.el9.src.rpm) and not as a snapshot build (initoverlayfs-0.98-0.202312131810.gitefcc221.el9.src.rpm). That should be fixed, if we want to include those RPMs into some snaphot builds repo (for example under centos-automotive-sig group) and make them consumable for other testers

@mwperina thanks do you refer running to something like this ? build-scripts/version.sh

So BlueChi has that support, so if you want to inspire, please take a look at those files:

https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/build-rpm.sh https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/build-srpm.sh

Above 2 files are not needed for packit, they are here for previous GH build/test integration and for local command line convenience.

Below files are required for packit integration: https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-archive.sh https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-spec.sh https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/version.sh https://github.com/eclipse-bluechi/bluechi/blob/main/.packit.yml#L20

But maybe it can be simplifed for initoverlayfs, which is much smaller project

Thanks, much appreciated

Tests are run by packit through tmt in testsing-farm Adding integration plan and tier-0 test verifying initoverlayfs setup Adding packit package builds for tests Signed-off-by: Yariv Rachmani <[email protected]>

mwperina · 2023-12-14T12:16:22Z

Unfortunately it's not enough, you still need to convert spec file to a template and replace version/release in this template per build:
https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-spec.sh

Signed-off-by: Yariv Rachmani <[email protected]>

ericcurtin

LGTM, we can do follow on work in the next PR if this is green

ericcurtin · 2023-12-14T12:26:13Z

I wish there was a auto-merge if build is green button here like we have in gitlab, it's useful...

ericcurtin · 2023-12-14T12:28:57Z

I found it in settings and turned it on, maybe the next PR will have the option

Yarboa · 2023-12-14T12:29:38Z

Unfortunately it's not enough, you still need to convert spec file to a template and replace version/release in this template per build: https://github.com/eclipse-bluechi/bluechi/blob/main/build-scripts/create-spec.sh

Noticed that. yes, lets wait

Now it looks good
'package_version': '0.98-0.202312141231.git4c998f9',

Yarboa requested review from ericcurtin, rhatdan, dougsland and masneyb as code owners November 30, 2023 17:19

Yarboa marked this pull request as draft November 30, 2023 17:20

Yarboa changed the title ~~Adding tmt tier-0 test~~ Adding tmt packit automation Nov 30, 2023

ericcurtin approved these changes Nov 30, 2023

View reviewed changes

Yarboa mentioned this pull request Nov 30, 2023

initoverlayfs is failing to boot after install on c9s #29

Open

ericcurtin marked this pull request as ready for review December 1, 2023 21:21

Yarboa force-pushed the add-packit-app branch from b0cdec5 to 855027c Compare December 3, 2023 06:34

ericcurtin reviewed Dec 3, 2023

View reviewed changes

integration/plans/tier-0.fmf Show resolved Hide resolved

Yarboa force-pushed the add-packit-app branch from 688ed01 to 28f40e1 Compare December 3, 2023 16:26

lsm5 requested changes Dec 4, 2023

View reviewed changes

.packit.yaml Outdated Show resolved Hide resolved

lsm5 reviewed Dec 4, 2023

View reviewed changes

.packit.yaml Show resolved Hide resolved

Yarboa force-pushed the add-packit-app branch 2 times, most recently from 4336f0b to df6f9d4 Compare December 4, 2023 13:24

Yarboa force-pushed the add-packit-app branch 2 times, most recently from 96ce364 to d22a531 Compare December 7, 2023 13:03

mwperina approved these changes Dec 7, 2023

View reviewed changes

Yarboa force-pushed the add-packit-app branch from d22a531 to 58e73fb Compare December 10, 2023 14:46

Yarboa mentioned this pull request Dec 11, 2023

Initoverlayfs 0.98 is broken #42

Closed

Yarboa force-pushed the add-packit-app branch from 58e73fb to efcc221 Compare December 13, 2023 18:04

Adding tmt tier-0 test

9d2a590

Tests are run by packit through tmt in testsing-farm Adding integration plan and tier-0 test verifying initoverlayfs setup Adding packit package builds for tests Signed-off-by: Yariv Rachmani <[email protected]>

Yarboa force-pushed the add-packit-app branch from efcc221 to 20800b9 Compare December 14, 2023 11:49

Adding support with versioning for non snapshot builds

4c998f9

Signed-off-by: Yariv Rachmani <[email protected]>

Yarboa force-pushed the add-packit-app branch from 20800b9 to 4c998f9 Compare December 14, 2023 12:22

ericcurtin approved these changes Dec 14, 2023

View reviewed changes

Yarboa merged commit 4495423 into containers:main Dec 14, 2023
5 checks passed

Yarboa mentioned this pull request Jan 8, 2024

pipeline for testing changes #5

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding tmt packit automation #28

Adding tmt packit automation #28

Yarboa commented Nov 30, 2023 •

edited

Loading

ericcurtin commented Nov 30, 2023

dougsland commented Nov 30, 2023

ericcurtin commented Dec 1, 2023

ericcurtin commented Dec 1, 2023

lsm5 commented Dec 4, 2023

mwperina left a comment

mwperina commented Dec 7, 2023

packit-as-a-service bot commented Dec 7, 2023

Yarboa commented Dec 7, 2023 •

edited

Loading

ericcurtin commented Dec 7, 2023

mwperina commented Dec 8, 2023

packit-as-a-service bot commented Dec 8, 2023

mwperina commented Dec 8, 2023

mwperina commented Dec 8, 2023

Yarboa commented Dec 8, 2023

Yarboa commented Dec 11, 2023 •

edited

Loading

ericcurtin commented Dec 13, 2023

mwperina commented Dec 14, 2023

Yarboa commented Dec 14, 2023

mwperina commented Dec 14, 2023 •

edited

Loading

Yarboa commented Dec 14, 2023

mwperina commented Dec 14, 2023

ericcurtin left a comment

ericcurtin commented Dec 14, 2023

ericcurtin commented Dec 14, 2023

Yarboa commented Dec 14, 2023 •

edited

Loading

Adding tmt packit automation #28

Adding tmt packit automation #28

Conversation

Yarboa commented Nov 30, 2023 • edited Loading

ericcurtin commented Nov 30, 2023

dougsland commented Nov 30, 2023

ericcurtin commented Dec 1, 2023

ericcurtin commented Dec 1, 2023

lsm5 commented Dec 4, 2023

mwperina left a comment

Choose a reason for hiding this comment

mwperina commented Dec 7, 2023

packit-as-a-service bot commented Dec 7, 2023

Yarboa commented Dec 7, 2023 • edited Loading

ericcurtin commented Dec 7, 2023

mwperina commented Dec 8, 2023

packit-as-a-service bot commented Dec 8, 2023

mwperina commented Dec 8, 2023

mwperina commented Dec 8, 2023

Yarboa commented Dec 8, 2023

Yarboa commented Dec 11, 2023 • edited Loading

ericcurtin commented Dec 13, 2023

mwperina commented Dec 14, 2023

Yarboa commented Dec 14, 2023

mwperina commented Dec 14, 2023 • edited Loading

Yarboa commented Dec 14, 2023

mwperina commented Dec 14, 2023

ericcurtin left a comment

Choose a reason for hiding this comment

ericcurtin commented Dec 14, 2023

ericcurtin commented Dec 14, 2023

Yarboa commented Dec 14, 2023 • edited Loading

Yarboa commented Nov 30, 2023 •

edited

Loading

Yarboa commented Dec 7, 2023 •

edited

Loading

Yarboa commented Dec 11, 2023 •

edited

Loading

mwperina commented Dec 14, 2023 •

edited

Loading

Yarboa commented Dec 14, 2023 •

edited

Loading