-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow run/exec -e with equals sign in value #860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs unit tests. Right now there's no framework to write tests for root compose_run easily, so it may not make sense to write them just right now, but wait until the framework exists.
Happy to add unit tests where appropriate, but I'm a little confused; is there a place that would make sense to add them now? |
On a second look a different approach is possible in this particular case.
Same with |
Fixes: #798 Signed-off-by: Ari Pollak <[email protected]>
Signed-off-by: Ari Pollak <[email protected]>
Signed-off-by: Ari Pollak <[email protected]>
@p12tic how does it look now? Specfying all the expected args in the passed |
@aripollak I agree with the entirety of your comment. The PR looks good, thanks! |
Fixes: #798