Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update vite to v6.0.2 and @sveltejs/vite-plugin-svelte to v5.0.1 #2212

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

chore: update vite to v6.0.2 and @sveltejs/vite-plugin-svelte to v5.0.1 #2212

wants to merge 2 commits into from

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Dec 4, 2024 •
edited
Loading

What does this PR do?

  • update vite to v6.0.2
  • update @sveltejs/vite-plugin-svelte to v5.0.1

Screenshot / video of UI

What issues does this PR fix or reference?

How to test this PR?

@benoitf
chore: update vite to v6.0.2
f5950ec 
Signed-off-by: Florent Benoit <[email protected]>
@benoitf benoitf requested review from jeffmaury and a team as code owners December 4, 2024 22:56
gastoner
gastoner approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@gastoner gastoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LGTM

axel7083
axel7083 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@axel7083 axel7083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bump

@benoitf
Copy link
Collaborator Author

benoitf commented Dec 5, 2024

I need to review it again as it's making the e2e failing

@benoitf benoitf marked this pull request as draft December 5, 2024 12:41
@benoitf benoitf changed the title chore: update vite to v6.0.2 chore: update vite to v6.0.2 and @sveltejs/vite-plugin-svelte to v5.0.1 Dec 5, 2024
@benoitf benoitf marked this pull request as ready for review December 5, 2024 15:51
@benoitf
Copy link
Collaborator Author

benoitf commented Dec 5, 2024

@axel7083 @gastoner I had to update also the vite-plugin-svelte plugin

the vite-plugin-svelte v4 is not compliant with vite v6
and vite-plugin-svelte v5 is not compliant with vite v5

@benoitf
Copy link
Collaborator Author

benoitf commented Dec 5, 2024

hm ok looks like it's broken differently now

@benoitf benoitf marked this pull request as draft December 5, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastoner gastoner gastoner approved these changes

@axel7083 axel7083 axel7083 approved these changes

@jeffmaury jeffmaury Awaiting requested review from jeffmaury jeffmaury is a code owner

@dgolovin dgolovin Awaiting requested review from dgolovin dgolovin is a code owner automatically assigned from containers/podman-desktop-reviewers

@SoniaSandler SoniaSandler Awaiting requested review from SoniaSandler SoniaSandler is a code owner automatically assigned from containers/podman-desktop-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benoitf @axel7083 @gastoner