libpod: correctly pass env so alternative locales work

[haircommander]

in addition to b6167ce we also need to pass LANG. Do so, and add a test to verify

Does this PR introduce a user-facing change?

fixes containers/conmon#272

Fix a bug where locales weren't passed to conmon correctly, resulting in a crash if some characters were specified over CLI

[rhatdan]

/approve
LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

Tests are failing on (1) all debian and (2) all containerized. Finding the common factor is left as an exercise for the reader.

[github-actions]

A friendly reminder that this PR had no activity for 30 days.

[vrothberg]

Friendly ping

[haircommander]

sorry I don't have bandwidth to find the issue with the failing tests. Does anyone have any to help me?

[edsantiago]

In debian-12 I see:

... --log-opt tag=äöüß quay.io/libpod/alpine:latest echo podman
conmon: option parsing failed: Invalid byte sequence in conversion input

Same in f38 container.

Maybe an old/bad version of conmon? Might be worth rebasing on main, since I think we have a new Debian VM?

Containers: maybe this diff could help?

diff --git a/contrib/cirrus/lib.sh b/contrib/cirrus/lib.sh
index 3e88fed73..d55f034f4 100644
--- a/contrib/cirrus/lib.sh
+++ b/contrib/cirrus/lib.sh
@@ -96,7 +96,7 @@ EPOCH_TEST_COMMIT="$CIRRUS_BASE_SHA"                                                                                                         
 PASSTHROUGH_ENV_EXACT='CGROUP_MANAGER|DEST_BRANCH|DISTRO_NV|GOCACHE|GOPATH|GOSRC|NETWORK_BACKEND|OCI_RUNTIME|ROOTLESS_USER|SCRIPT_BASE|SKIP_USERNS|EC2_INST_TYPE|PODMAN_DB'
 
 # List of envariable patterns which must match AT THE BEGINNING of the name.
-PASSTHROUGH_ENV_ATSTART='CI|TEST'
+PASSTHROUGH_ENV_ATSTART='CI|TEST|LC_|LANG'
 
 # List of envariable patterns which can match ANYWHERE in the name
 PASSTHROUGH_ENV_ANYWHERE='_NAME|_FQIN'

[haircommander]

thanks @edsantiago I have adopted your suggestions :)

[edsantiago]

Grumble. Try this instead:

PASSTHROUGH_ENV_ATSTART='CI|LANG|LC_|TEST'

Reason:

    # because passthrough_envars always returns a sorted list and (see
    # subshell comments above) we're incrementally adding to our env.

[edsantiago]

Oh well, it was worth a try. Someone with access to hack/ci-vm.sh needs to look at what's going on in Debian.

[Luap99]

I took a quick look, I think this locale is simply not installed/generated on debian
From a hack/get_ci_vm I see

# locale -a
C
C.utf8
POSIX

So I would assume the answer is to make sure en_US.UTF-8 is there as well with locale-gen en_US.UTF-8, properly best to do this once at VM image build time.

[Luap99]

Closing in favor of #19635