Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

troubleshooting: adjust home path in tip 44 #24065

Conversation

eriksjolund
Copy link
Contributor

Modify the home dir path to make the troubleshooting tip more robust against mistakes.

userdel with force argument tries to remove home dir path "/" according to

(I haven't tried it myself)

Does this PR introduce a user-facing change?

None

@eriksjolund eriksjolund force-pushed the troubleshooting_adjust_homedir branch 3 times, most recently from 7a02f9b to 3c5ac59 Compare September 25, 2024 05:47
Modify the home dir path in troubleshooting tip 44
to prevent files from being accidentally removed.

userdel with force argument tries to remove home dir path "/"
according to
shadow-maint/shadow#1050

Signed-off-by: Erik Sjölund <[email protected]>
@eriksjolund
Copy link
Contributor Author

I'm not sure what's best, adding --no-create-home or not. (Probably it does not matter)

I would have liked to use sysusers.d but I didn't get that to work when I tried it on Fedora CoreOS.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eriksjolund, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@baude
Copy link
Member

baude commented Sep 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8cc4781 into containers:main Sep 25, 2024
41 checks passed
@eriksjolund eriksjolund deleted the troubleshooting_adjust_homedir branch September 25, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants