api: Remove double close in ImportImages #24269
Conversation
tmpfile is closed using defer. Remove explicit closing. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Tigran Sogomonian <[email protected]>
github-actions
bot
added
the
kind/api-change
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mi4r, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
pkg/api/handlers/libpod/images.go
Outdated
| @@ -410,7 +410,6 @@ func ImagesImport(w http.ResponseWriter, r *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| tmpfile.Close() | |||
There was a problem hiding this comment.
While the current code is not doing this correct either but I think there is a real reason to call close here and not via defer close(). close() can return real write errors so it likely is best to ensure the file is closed and we check that there was no error before passing that to file path to import.
One close is returned to its place, the second one is replaced in the body of the error condition. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Тигран Согомонян <[email protected]>
|
There were accidently added changes |
|
I will form new clean merge request |
|
please see my comments in #24277 |
tmpfile is closed using defer. Remove explicit closing.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Does this PR introduce a user-facing change?