Update gvproxy to v0.8.0 and disable ssh port forwarding on wsl #24394
Conversation
Signed-off-by: Gunjan Vyas <[email protected]>
Fixes: containers#24070 This change disables ssh port forwarding on wsl to prevent port conflict with crc Signed-off-by: Gunjan Vyas <[email protected]>
Signed-off-by: Gunjan Vyas <[email protected]>
|
is it possible to add a test to this PR? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, vyasgun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
lgtm |
Are there some 'high level' tests which start podman-machine/gvproxy on Windows/wsl? We could add a test there to check that on the host, nothing listens on port 2222 |
|
These are some machine e2e SSH tests here. The README.md file has instructions to run them (on windows too). |
|
/packit retest-failed |
yes ofc there are! |
vyasgun
force-pushed
the
pr/gvproxy080
branch
from
4218495
to
213de16
Compare
|
Thanks for the reviews! I have added a small modification to the windows init test to ensure port 2222 is open |
vyasgun
force-pushed
the
pr/gvproxy080
branch
from
213de16
to
3645d55
Compare
Signed-off-by: Gunjan Vyas <[email protected]>
vyasgun
force-pushed
the
pr/gvproxy080
branch
from
3645d55
to
c9014e8
Compare
This fixes #20327.
This change will pass
-1to the-ssh-portflag ofgvproxyto disable port forwarding on wsl which will prevent port conflict with crc.Does this PR introduce a user-facing change?
No