go.mod vendor: ensure we never have the toolchain directive set #24403
+9
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
|
lgtm |
edsantiago
approved these changes
Oct 31, 2024
go.mod
Outdated
Comment on lines
3
to
4
| // Warning: Ensure the "go" and "toolchain" versions match exactly to prevent unwanted auto-updates. | ||
| // That generally means there should be no toolchain directive present. |
There was a problem hiding this comment.
This wording confuses me a little: I might spend myself looking for a toolchain line. Would it make sense to rephrase as something closer to
// Warning: if there is a "toolchain" directive anywhere in this file (and most of the time there shouldn't be), its version must be an exact match to the "go" directive
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Like our main go.mod we never want to force a specific toolchain. Signed-off-by: Paul Holzinger <[email protected]>
Ensure nobody modifies files directly there. Signed-off-by: Paul Holzinger <[email protected]>
We never want the toolchain as the default is to use the same as the go version. So the only purpose of toolchain is to force a newer compiler than necessary which we do not want as we are getting build by many different distributions and block builds that would otherwise work fine is just not helpful to anyone. Also update the go.mod comments remind people that there should be no toolchain. The make vendor target with the toolchain will now guarantee this so the CI will fail otherwise. Signed-off-by: Paul Holzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?