EB-1201: Edit button is showing in live editor window #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vishvam10
deleted the
EB-1201-edit-button-is-showing-in-live-editor-window
branch
Vishvam10
restored the
EB-1201-edit-button-is-showing-in-live-editor-window
branch
Deepak-Kharah
requested changes
Mar 12, 2024
Deepak-Kharah
approved these changes
Mar 12, 2024
aravindbuilt
deleted the
EB-1201-edit-button-is-showing-in-live-editor-window
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Story
Work has been completed on this Jira story : https://contentstack.atlassian.net/browse/EB-1201
Overview
This PR fixes a bug where the edit button appeared in the live editor. It introduces and takes the help of
Preact Effectsfor better state updationChanges Made
effect()and update rendering logic ineditButton.ts