-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve error handling and ensure coroutines continue correctly in case of failure #3763
fix: Improve error handling and ensure coroutines continue correctly in case of failure #3763
Conversation
…in case of failure
…when the file changes
✅ Deploy Preview for continuedev canceled.
|
@lkk214 sorry for the delay in review here! I resolved the merge conflict that was on this PR and pushed up the changes, just needed to handle some updated object restructuring logic for apply. Before we merge, mind providing a few manual testing instructions for me to walk through the changes? Looks good overall but worth a double check. |
@Patrick-Erichsen Thanks for resolving the merge conflict. |
# Conflicts: # extensions/intellij/src/main/kotlin/com/github/continuedev/continueintellijextension/activities/ContinuePluginStartupActivity.kt
Hi @lkk214 , apologies for the delay here! We've been pretty busy preparing for the 1.0 launch the last few weeks. The failing tests are likely just flake here. If you could get the merge conflict resolved I'd love to still get this PR merged. Also lmk if there's anything I can do to verify the changes/any tests that might be helpful here. Appreciate the work! |
# Conflicts: # extensions/intellij/src/main/kotlin/com/github/continuedev/continueintellijextension/continue/IdeProtocolClient.kt
Hi @Patrick-Erichsen , first of all, congratulations on launching version 1.0, really great work. |
Appreciate the kind words @lkk214 , and thanks again for the improvements here! Very much appreciated |
Description