Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve error handling and ensure coroutines continue correctly in case of failure #3763

Merged
merged 11 commits into from
Mar 4, 2025

Conversation

lkk214
Copy link
Contributor

@lkk214 lkk214 commented Jan 18, 2025

Description

  • Improve error handling and ensure coroutines continue correctly in case of failure.
  • Simplify isInjectedFile logic and reduce unnecessary closures.
  • Ensure CancelAutocompleteAction updates on EDT.
  • Ensure that the state is cleared after refresh, and files->uris when the file changes.

Copy link

netlify bot commented Jan 18, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 1e96bfb
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67c20c36a23d1b00081e6766

@Patrick-Erichsen
Copy link
Collaborator

@lkk214 sorry for the delay in review here! I resolved the merge conflict that was on this PR and pushed up the changes, just needed to handle some updated object restructuring logic for apply.

Before we merge, mind providing a few manual testing instructions for me to walk through the changes? Looks good overall but worth a double check.

@lkk214
Copy link
Contributor Author

lkk214 commented Feb 1, 2025

@Patrick-Erichsen Thanks for resolving the merge conflict.
I have updated the code and verified no issues and it is expected.

sestinj and others added 3 commits February 4, 2025 12:43
# Conflicts:
#	extensions/intellij/src/main/kotlin/com/github/continuedev/continueintellijextension/activities/ContinuePluginStartupActivity.kt
@Patrick-Erichsen
Copy link
Collaborator

Hi @lkk214 , apologies for the delay here! We've been pretty busy preparing for the 1.0 launch the last few weeks.

The failing tests are likely just flake here. If you could get the merge conflict resolved I'd love to still get this PR merged. Also lmk if there's anything I can do to verify the changes/any tests that might be helpful here. Appreciate the work!

lkk214 added 2 commits March 1, 2025 02:35
# Conflicts:
#	extensions/intellij/src/main/kotlin/com/github/continuedev/continueintellijextension/continue/IdeProtocolClient.kt
@lkk214
Copy link
Contributor Author

lkk214 commented Feb 28, 2025

Hi @Patrick-Erichsen , first of all, congratulations on launching version 1.0, really great work.
I've resolved the merge conflicts and made minor adjustments to the code just to avoid unexpected errors from multiple resumes.

@Patrick-Erichsen Patrick-Erichsen merged commit cae8c89 into continuedev:main Mar 4, 2025
31 checks passed
@Patrick-Erichsen
Copy link
Collaborator

Appreciate the kind words @lkk214 , and thanks again for the improvements here! Very much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants