Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eslint upgrades #430

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Eslint upgrades #430

wants to merge 2 commits into from

Conversation

hussainweb
Copy link
Member

Manually upgrade dependencies because dependabot group is probably insufficient. In this case, we need to add prettier to the group to allow dependencies to be resolved.

@hussainweb
Copy link
Member Author

This fails as Typescript eslint plugins don't support Eslint 9 yet. See typescript-eslint/typescript-eslint#8211.

@AlviMurtaza
Copy link
Contributor

Yes, the same was happening on my local as well, as I mentioned the dependencies are not supporting the latest version of eslint.

@hussainweb
Copy link
Member Author

There is a new (alpha) version of typescript-eslint plugin that supports eslint v9. It's still alpha at this time and we can wait until there is a proper release.

@hussainweb
Copy link
Member Author

Many of the dependencies from here are handled in other PRs. Now, only eslint is remaining once we have updates to typescript-eslint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlviMurtaza AlviMurtaza Awaiting requested review from AlviMurtaza

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hussainweb @AlviMurtaza