Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add console Application to DI container exported types #53

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

redwormik
Copy link

Hello,
when I turn off type exporting of Nette DI container like this:

di:
	export:
		parameters: no
		tags: no
		types:

I have to add Contributte\Console\Application to the types to get it by type in bin/console, while e.g. Nette\Application\Application works "out-of-the-box", because it is added to compiler's exported types in ApplicationExtension, i.e. it is always exported.

This PR likewise adds Contributte\Console\Application to compiler's exported types, so it works even when other types are not exported.

@redwormik
Copy link
Author

@f3l1x Hello, can I do anything to help this? If you do not think it is a good idea, feel free to close it 🙂

@f3l1x
Copy link
Member

f3l1x commented Mar 20, 2021

I like it, could you please export types before end of loadConfiguration? With comment // Export types. Thx.

@f3l1x f3l1x merged commit 5498935 into contributte:master Mar 20, 2021
@f3l1x
Copy link
Member

f3l1x commented Mar 20, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants