Skip to content

Add ROS actions in SCXML #92

Add ROS actions in SCXML

Add ROS actions in SCXML #92

Triggered via pull request August 20, 2024 09:37
Status Success
Total duration 1m 6s
Artifacts

lint.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

31 errors and 83 warnings
jani_generator ⏩ isort: jani_generator/src/jani_generator/jani_entries/jani_constant.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/jani_entries/jani_variable.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/ros_helpers/ros_services.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/bt_converter.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_root.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/bt_utils.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_param.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/xml_utils.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_transition.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_timer.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_field.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/ros_utils.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_expression.py#L52
Parameterized generics cannot be used with class or instance checks [misc]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_expression.py#L52
Argument 2 to "isinstance" has incompatible type "object"; expected "Union[type, UnionType, Tuple[Union[type, UnionType, Tuple[Any, ...]], ...]]" [arg-type]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_convince_expression_expansion.py#L207
Unsupported operand types for % ("int" and "None") [operator]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_convince_expression_expansion.py#L208
Unsupported operand types for % ("int" and "None") [operator]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_constant.py#L63
Item "None" of "Optional[JaniValue]" has no attribute "is_valid" [union-attr]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_constant.py#L65
Item "None" of "Optional[JaniValue]" has no attribute "value" [union-attr]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/xml_utils.py#L83
Incompatible types in assignment (expression has type "Tuple[Union[Type[ScxmlBase], Type[str]], ...]", variable has type "Tuple[Union[Type[ScxmlBase], Type[str]]]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/xml_utils.py#L84
Argument 2 to "get_children_as_scxml" has incompatible type "Tuple[Union[Type[ScxmlBase], Type[str]]]"; expected "Tuple[Type[ScxmlBase]]" [arg-type]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/xml_utils.py#L105
Incompatible types in assignment (expression has type "Union[str, ScxmlBase, None]", variable has type "Optional[str]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_transition.py#L105
Item "None" of "Optional[List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]]" has no attribute "__iter__" (not iterable) [union-attr]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L38
Incompatible default for argument "on_entry" (default has type "None", argument has type "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L39
Incompatible default for argument "on_exit" (default has type "None", argument has type "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L40
Incompatible default for argument "body" (default has type "None", argument has type "List[ScxmlTransition]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L179
Argument "on_entry" to "ScxmlState" has incompatible type "Optional[List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]]"; expected "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]" [arg-type]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L179
Argument "on_exit" to "ScxmlState" has incompatible type "Optional[List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]]"; expected "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]" [arg-type]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_topic.py#L52
Incompatible types in assignment (expression has type "Union[str, ScxmlBase, None]", variable has type "Optional[str]") [assignment]
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_service.py#L51
No value for argument 'valid_types' in function call
as2fm_common ⏩ mypy
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ mypy
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
as2fm_common ⏩ isort
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ isort
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ isort
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
jani_generator ⏩ isort
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
as2fm_common ⏩ flake8: as2fm_common/src/as2fm_common/common.py#L28
line too long (92 > 79 characters)
as2fm_common ⏩ flake8
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ flake8
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L28
line too long (92 > 79 characters)
as2fm_common ⏩ pycodestyle
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ pycodestyle
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L32
line too long (80 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L40
line too long (83 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L42
line too long (80 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L53
line too long (85 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L69
line too long (82 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L83
line too long (81 > 79 characters)
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/common.py#L22
String statement has no effect
as2fm_common ⏩ pylint
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ pylint
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
scxml_converter ⏩ isort
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
scxml_converter ⏩ isort
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ mypy
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
jani_generator ⏩ mypy
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
scxml_converter ⏩ flake8: scxml_converter/src/scxml_converter/scxml_converter.py#L23
'xml.etree.ElementTree as ET' imported but unused
scxml_converter ⏩ flake8: scxml_converter/src/scxml_converter/scxml_converter.py#L28
'scxml_converter.scxml_entries.ScxmlRoot' imported but unused
scxml_converter ⏩ flake8: scxml_converter/src/scxml_converter/scxml_converter.py#L28
'scxml_converter.scxml_entries.ScxmlRosDeclarationsContainer' imported but unused
scxml_converter ⏩ mypy
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
scxml_converter ⏩ mypy
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ flake8: jani_generator/src/jani_generator/main.py#L32
line too long (80 > 79 characters)
jani_generator ⏩ flake8: jani_generator/src/jani_generator/main.py#L40
line too long (83 > 79 characters)
jani_generator ⏩ flake8: jani_generator/src/jani_generator/main.py#L42
line too long (80 > 79 characters)
jani_generator ⏩ flake8: jani_generator/src/jani_generator/main.py#L53
line too long (85 > 79 characters)
jani_generator ⏩ flake8: jani_generator/src/jani_generator/main.py#L69
line too long (82 > 79 characters)
jani_generator ⏩ flake8: jani_generator/src/jani_generator/main.py#L83
line too long (81 > 79 characters)
jani_generator ⏩ pylint: jani_generator/src/jani_generator/convince_jani_helpers/convince_to_plain_jani.py#L86
TODO: Discuss the possibility of generating a base automata for each robot + standard edges
jani_generator ⏩ pylint: jani_generator/src/jani_generator/scxml_helpers/scxml_expression.py#L48
Unnecessary "elif" after "return", remove the leading "el" from "elif"
jani_generator ⏩ pylint: jani_generator/src/jani_generator/scxml_helpers/scxml_expression.py#L61
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
jani_generator ⏩ pylint: jani_generator/src/jani_generator/scxml_helpers/scxml_event_processor.py#L124
TODO: Dots are likely to create problems in the future. Consider replacing them
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L135
TODO: Make BT rate configurable, e.g. from main.xml
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L35
Class name "BT_EVENT_TYPE" doesn't conform to PascalCase naming style
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L43
Missing function or method docstring
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/scxml_converter.py#L75
TODO: Unused, keeping as reference to output types in low level SCXML
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/scxml_converter.py#L23
Unused xml.etree.ElementTree imported as ET