Skip to content
Lint

Prepare features before integration week #116

Sign in to view logs

Prepare features before integration week

Prepare features before integration week #116

Triggered via pull request September 3, 2024 09:36
@MarcoLm993MarcoLm993
synchronize #26
develop
Status Success
Total duration 1m 2s
Artifacts –

lint.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

44 errors and 80 warnings
as2fm_common ⏩ mypy: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L50
Parameterized generics cannot be used with class or instance checks [misc]
as2fm_common ⏩ mypy: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L50
Argument 2 to "isinstance" has incompatible type "object"; expected "Union[type, UnionType, Tuple[Union[type, UnionType, Tuple[Any, ...]], ...]]" [arg-type]
jani_generator ⏩ isort: jani_generator/src/jani_generator/scxml_helpers/scxml_expression.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/scxml_helpers/scxml_event_processor.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/scxml_helpers/top_level_interpreter.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/scxml_helpers/scxml_tags.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/jani_entries/jani_constant.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/jani_entries/jani_variable.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/ros_helpers/ros_communication_handler.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/ros_helpers/ros_action_handler.py#L1
Imports are incorrectly sorted and/or formatted.
as2fm_common ⏩ isort: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/ros_helpers/ros_service_handler.py#L1
Imports are incorrectly sorted and/or formatted.
as2fm_common ⏩ isort: as2fm_common/src/as2fm_common/common.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/xml_utils.py#L87
Argument 2 to "get_children_as_scxml" has incompatible type "Tuple[Union[Type[ScxmlBase], Type[str]], ...]"; expected "Iterable[Type[ScxmlBase]]" [arg-type]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/xml_utils.py#L108
Incompatible types in assignment (expression has type "Union[str, ScxmlBase, None]", variable has type "Optional[str]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_transition.py#L106
Item "None" of "Optional[List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]]" has no attribute "__iter__" (not iterable) [union-attr]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L64
Incompatible default for argument "on_entry" (default has type "None", argument has type "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L65
Incompatible default for argument "on_exit" (default has type "None", argument has type "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L66
Incompatible default for argument "body" (default has type "None", argument has type "List[ScxmlTransition]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L123
Value expression in dictionary comprehension has incompatible type "Type[RosCallback]"; expected type "Type[ScxmlTransition]" [misc]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L206
Argument "on_entry" to "ScxmlState" has incompatible type "Optional[List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]]"; expected "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]" [arg-type]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L206
Argument "on_exit" to "ScxmlState" has incompatible type "Optional[List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]]"; expected "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]" [arg-type]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_topic.py#L93
Argument 1 to "RosTopicCallback" has incompatible type "Optional[str]"; expected "Union[str, RosDeclaration]" [arg-type]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_property.py#L132
Value expression in dictionary comprehension has incompatible type "Union[str, int, float, Dict[Any, Any]]"; expected type "str" [misc]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_expression.py#L60
Parameterized generics cannot be used with class or instance checks [misc]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_expression.py#L60
Argument 2 to "isinstance" has incompatible type "object"; expected "Union[type, UnionType, Tuple[Union[type, UnionType, Tuple[Any, ...]], ...]]" [arg-type]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_convince_expression_expansion.py#L207
Unsupported operand types for % ("int" and "None") [operator]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_convince_expression_expansion.py#L208
Unsupported operand types for % ("int" and "None") [operator]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_constant.py#L63
Item "None" of "Optional[JaniValue]" has no attribute "is_valid" [union-attr]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_constant.py#L65
Item "None" of "Optional[JaniValue]" has no attribute "value" [union-attr]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/scxml_helpers/scxml_tags.py#L109
"None" object is not iterable [misc]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/ros_helpers/ros_action_handler.py#L84
Argument 1 has incompatible type "Optional[str]"; expected "str" [arg-type]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/ros_helpers/ros_action_handler.py#L95
Argument 1 has incompatible type "Optional[str]"; expected "str" [arg-type]
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/bt_converter.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_root.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/bt_utils.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_param.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_base.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/xml_utils.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_transition.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_timer.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/utils.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_action_server.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ pylint: jani_generator/src/jani_generator/jani_entries/jani_variable.py#L40
Abstract class 'MutableSequence' with abstract methods instantiated
as2fm_common ⏩ mypy
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ mypy
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ flake8: jani_generator/src/jani_generator/__init__.py#L1
no newline at end of file
jani_generator ⏩ flake8: jani_generator/src/jani_generator/convince_jani_helpers/__init__.py#L1
no newline at end of file
jani_generator ⏩ flake8
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
jani_generator ⏩ flake8
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/__init__.py#L1
no newline at end of file
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L32
line too long (80 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L40
line too long (83 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L42
line too long (80 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L53
line too long (85 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L69
line too long (82 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L83
line too long (81 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/convince_jani_helpers/__init__.py#L1
no newline at end of file
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/convince_jani_helpers/convince_to_plain_jani.py#L40
line too long (98 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/convince_jani_helpers/convince_to_plain_jani.py#L42
line too long (93 > 79 characters)
as2fm_common ⏩ flake8
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ flake8
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L29
line too long (92 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L41
line too long (82 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L60
line too long (80 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L62
line too long (92 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L79
line too long (80 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L32
line too long (80 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L48
line too long (99 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L56
line too long (88 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L61
line too long (84 > 79 characters)
as2fm_common ⏩ pycodestyle
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
scxml_converter ⏩ pycodestyle: scxml_converter/src/scxml_converter/bt_converter.py#L31
line too long (84 > 79 characters)
scxml_converter ⏩ pycodestyle: scxml_converter/src/scxml_converter/bt_converter.py#L93
line too long (85 > 79 characters)
scxml_converter ⏩ pycodestyle: scxml_converter/src/scxml_converter/bt_converter.py#L96
line too long (93 > 79 characters)
scxml_converter ⏩ pycodestyle: scxml_converter/src/scxml_converter/bt_converter.py#L113
line too long (92 > 79 characters)
scxml_converter ⏩ pycodestyle: scxml_converter/src/scxml_converter/bt_converter.py#L143
line too long (80 > 79 characters)
scxml_converter ⏩ pycodestyle: scxml_converter/src/scxml_converter/scxml_entries/bt_utils.py#L25
line too long (85 > 79 characters)
scxml_converter ⏩ pycodestyle: scxml_converter/src/scxml_converter/scxml_entries/bt_utils.py#L28
line too long (88 > 79 characters)
scxml_converter ⏩ pycodestyle: scxml_converter/src/scxml_converter/scxml_entries/bt_utils.py#L33
line too long (82 > 79 characters)
scxml_converter ⏩ pycodestyle: scxml_converter/src/scxml_converter/scxml_entries/bt_utils.py#L34
line too long (88 > 79 characters)
scxml_converter ⏩ pycodestyle: scxml_converter/src/scxml_converter/scxml_entries/bt_utils.py#L39
line too long (87 > 79 characters)
as2fm_common ⏩ isort
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ isort
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ isort
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
jani_generator ⏩ isort
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
scxml_converter ⏩ flake8
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
scxml_converter ⏩ flake8
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
scxml_converter ⏩ mypy
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
scxml_converter ⏩ mypy
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ mypy
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
jani_generator ⏩ mypy
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
scxml_converter ⏩ isort
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
scxml_converter ⏩ isort
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L28
Type alias name "BASIC_JS_TYPES" doesn't conform to predefined naming style
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L48
Consider explicitly re-raising using 'except Exception as exc' and 'raise RuntimeError(f"Failed to interpret JS expression: 'result = {expr}'. {msg_addition}") from exc'
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L50
Unnecessary "elif" after "return", remove the leading "el" from "elif"
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L53
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L53
Access to a protected member _obj of a client class
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L57
Access to a protected member _obj of a client class
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/common.py#L23
String statement has no effect
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/common.py#L63
Unnecessary "elif" after "return", remove the leading "el" from "elif"
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/common.py#L74
Unnecessary "elif" after "return", remove the leading "el" from "elif"
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/common.py#L88
Unnecessary "elif" after "return", remove the leading "el" from "elif"
jani_generator ⏩ pylint: jani_generator/src/jani_generator/__init__.py#L1
Final newline missing
jani_generator ⏩ pylint: jani_generator/src/jani_generator/main.py#L1
Missing module docstring
jani_generator ⏩ pylint: jani_generator/src/jani_generator/convince_jani_helpers/convince_to_plain_jani.py#L83
TODO
jani_generator ⏩ pylint: jani_generator/src/jani_generator/convince_jani_helpers/convince_to_plain_jani.py#L85
TODO: Discuss the perception part
jani_generator ⏩ pylint: jani_generator/src/jani_generator/convince_jani_helpers/convince_to_plain_jani.py#L86
TODO: Discuss the possibility of generating a base automata for each robot + standard edges
jani_generator ⏩ pylint: jani_generator/src/jani_generator/convince_jani_helpers/__init__.py#L1
Final newline missing
jani_generator ⏩ pylint: jani_generator/src/jani_generator/convince_jani_helpers/__init__.py#L1
Missing module docstring
jani_generator ⏩ pylint: jani_generator/src/jani_generator/scxml_helpers/scxml_expression.py#L33
Missing class docstring
jani_generator ⏩ pylint: jani_generator/src/jani_generator/scxml_helpers/scxml_expression.py#L63
Consider explicitly re-raising using 'except NotImplementedError as exc' and 'raise RuntimeError(f'Unsupported ecmascript: {ecmascript}') from exc'
jani_generator ⏩ pylint: jani_generator/src/jani_generator/scxml_helpers/scxml_expression.py#L65
Consider explicitly re-raising using 'except AssertionError as exc' and 'raise RuntimeError(f'Assertion from ecmascript: {ecmascript}') from exc'
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L135
TODO: Make BT rate configurable, e.g. from main.xml
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L35
Class name "BT_EVENT_TYPE" doesn't conform to PascalCase naming style
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L43
Missing function or method docstring
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L55
Too many local variables (27/15)
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L55
Too many branches (14/12)
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L55
Too many statements (62/50)
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/scxml_converter.py#L69
# TODO: Unused, keeping as reference to output types in low level SCXML
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/scxml_converter.py#L32
Unnecessary pass statement
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/scxml_entries/scxml_root.py#L38
Method 'as_plain_scxml' is abstract in class 'ScxmlBase' but is not overridden in child class 'ScxmlRoot'
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/scxml_entries/scxml_root.py#L38
Too many instance attributes (8/7)