Skip to content

Two visualizers

Two visualizers #163

Triggered via pull request September 25, 2024 16:23
@ct2034ct2034
synchronize #18
add/visualizer
Status Success
Total duration 1m 27s
Artifacts

lint.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

48 errors and 80 warnings
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/bt_converter.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_base.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/ros_utils.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_service.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_topic.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_transition.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/bt_utils.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_timer.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/xml_utils.py#L1
Imports are incorrectly sorted and/or formatted.
scxml_converter ⏩ isort: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/ros_helpers/ros_timer.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/ros_helpers/ros_action_handler.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/ros_helpers/ros_service_handler.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/scxml_helpers/scxml_event_processor.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/scxml_helpers/scxml_tags.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/scxml_helpers/scxml_expression.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/scxml_helpers/top_level_interpreter.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/scxml_helpers/scxml_event.py#L1
Imports are incorrectly sorted and/or formatted.
jani_generator ⏩ isort: jani_generator/src/jani_generator/jani_entries/jani_variable.py#L1
Imports are incorrectly sorted and/or formatted.
as2fm_common ⏩ isort: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L1
Imports are incorrectly sorted and/or formatted.
as2fm_common ⏩ isort: as2fm_common/src/as2fm_common/common.py#L1
Imports are incorrectly sorted and/or formatted.
as2fm_common ⏩ mypy: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L50
Parameterized generics cannot be used with class or instance checks [misc]
as2fm_common ⏩ mypy: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L50
Argument 2 to "isinstance" has incompatible type "object"; expected "Union[type, UnionType, Tuple[Union[type, UnionType, Tuple[Any, ...]], ...]]" [arg-type]
as2fm_common ⏩ mypy: as2fm_common/src/as2fm_common/common.py#L109
Too many arguments for "MutableSequence" [call-arg]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/xml_utils.py#L90
Argument 2 to "get_children_as_scxml" has incompatible type "Tuple[Union[Type[ScxmlBase], Type[str]], ...]"; expected "Iterable[Type[ScxmlBase]]" [arg-type]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/xml_utils.py#L111
Incompatible types in assignment (expression has type "Union[str, ScxmlBase, None]", variable has type "Optional[str]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L47
Value expression in dictionary comprehension has incompatible type "Type[RosCallback]"; expected type "Type[ScxmlTransition]" [misc]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L86
Incompatible default for argument "on_entry" (default has type "None", argument has type "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L87
Incompatible default for argument "on_exit" (default has type "None", argument has type "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L88
Incompatible default for argument "body" (default has type "None", argument has type "List[ScxmlTransition]") [assignment]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L211
Argument "on_entry" to "ScxmlState" has incompatible type "Optional[List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]]"; expected "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]" [arg-type]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_state.py#L211
Argument "on_exit" to "ScxmlState" has incompatible type "Optional[List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]]"; expected "List[Union[ScxmlAssign, ScxmlIf, ScxmlSend]]" [arg-type]
scxml_converter ⏩ mypy: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_timer.py#L44
Argument 1 to "float" has incompatible type "Optional[str]"; expected "Union[SupportsFloat, SupportsIndex, str, bytes, bytearray, memoryview, array[Any], mmap, _CData, PickleBuffer]" [arg-type]
jani_generator ⏩ pylint: jani_generator/src/jani_generator/jani_entries/jani_variable.py#L40
Abstract class 'MutableSequence' with abstract methods instantiated
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_property.py#L132
Value expression in dictionary comprehension has incompatible type "Union[str, int, float, Dict[Any, Any]]"; expected type "str" [misc]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_expression.py#L60
Parameterized generics cannot be used with class or instance checks [misc]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_expression.py#L60
Argument 2 to "isinstance" has incompatible type "object"; expected "Union[type, UnionType, Tuple[Union[type, UnionType, Tuple[Any, ...]], ...]]" [arg-type]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_expression.py#L196
Incompatible return value type (got "Union[Dict[Any, Any], int, float, List[Any]]", expected "Union[str, int, float, bool, Dict[Any, Any]]") [return-value]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_convince_expression_expansion.py#L210
Unsupported operand types for % ("int" and "None") [operator]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_convince_expression_expansion.py#L211
Unsupported operand types for % ("int" and "None") [operator]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_constant.py#L63
Item "None" of "Optional[JaniValue]" has no attribute "is_valid" [union-attr]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_constant.py#L65
Item "None" of "Optional[JaniValue]" has no attribute "value" [union-attr]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_utils.py#L58
Item "None" of "Optional[JaniVariable]" has no attribute "get_type" [union-attr]
jani_generator ⏩ mypy: jani_generator/src/jani_generator/jani_entries/jani_utils.py#L62
Item "None" of "Optional[JaniVariable]" has no attribute "get_init_expr" [union-attr]
jani_generator ⏩ flake8
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
jani_generator ⏩ flake8
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
as2fm_common ⏩ flake8
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ flake8
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
scxml_converter ⏩ isort
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
scxml_converter ⏩ isort
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ isort
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
jani_generator ⏩ isort
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L32
line too long (80 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L40
line too long (83 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L42
line too long (80 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L53
line too long (85 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L69
line too long (82 > 79 characters)
jani_generator ⏩ pycodestyle: jani_generator/src/jani_generator/main.py#L83
line too long (81 > 79 characters)
as2fm_common ⏩ isort
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ isort
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
as2fm_common ⏩ mypy
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
as2fm_common ⏩ mypy
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
scxml_converter ⏩ flake8
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
scxml_converter ⏩ flake8
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
scxml_converter ⏩ mypy
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
scxml_converter ⏩ mypy
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
jani_generator ⏩ pylint: jani_generator/src/jani_generator/convince_jani_helpers/convince_to_plain_jani.py#L86
TODO: Discuss the possibility of generating a base automata for each robot + standard edges
jani_generator ⏩ pylint: jani_generator/src/jani_generator/ros_helpers/ros_timer.py#L60
Unnecessary "elif" after "return", remove the leading "el" from "elif"
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L28
Type alias name "BASIC_JS_TYPES" doesn't conform to predefined naming style
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L48
Consider explicitly re-raising using 'except Exception as exc' and 'raise RuntimeError(f"Failed to interpret JS expression: 'result = {expr}'. {msg_addition}") from exc'
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L50
Unnecessary "elif" after "return", remove the leading "el" from "elif"
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L53
Access to a protected member _obj of a client class
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L55
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/ecmascript_interpretation.py#L61
Access to a protected member _obj of a client class
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/common.py#L23
String statement has no effect
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/common.py#L63
Unnecessary "elif" after "return", remove the leading "el" from "elif"
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/common.py#L74
Unnecessary "elif" after "return", remove the leading "el" from "elif"
as2fm_common ⏩ pylint: as2fm_common/src/as2fm_common/common.py#L88
Unnecessary "elif" after "return", remove the leading "el" from "elif"
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L29
line too long (92 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L41
line too long (82 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L60
line too long (80 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L62
line too long (92 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L79
line too long (80 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L99
line too long (80 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L103
line too long (81 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L104
line too long (90 > 79 characters)
as2fm_common ⏩ pycodestyle: as2fm_common/src/as2fm_common/common.py#L122
line too long (89 > 79 characters)
jani_generator ⏩ mypy
The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/[email protected], actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
jani_generator ⏩ mypy
The following actions use a deprecated Node.js version and will be forced to run on node20: szenius/[email protected], actions/checkout@v3, actions/checkout@v2, actions/setup-python@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L137
TODO: Make BT rate configurable, e.g. from main.xml
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L35
Class name "BT_EVENT_TYPE" doesn't conform to PascalCase naming style
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/bt_converter.py#L43
Missing function or method docstring
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_base.py#L168
__init__ method from base class 'ScxmlTransition' is not called
scxml_converter ⏩ pylint: scxml_converter/src/scxml_converter/scxml_entries/scxml_ros_base.py#L291
__init__ method from base class 'ScxmlSend' is not called