-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare RosConn Deliberation workshop example #32
Conversation
bdd0402
to
de7cb6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhh, that's a huge PR. Thank you very much for all the work 👍 Looks good to me, as far as I can tell. Not sure if we should wait for Christian's review until merging.
Yes, let's wait for Christian. I will also turn his example into a test, so we can consider this PR truly complete. |
Co-authored-by: Marco Lampacrescia <[email protected]> Signed-off-by: Christian Henkel <[email protected]>
Signed-off-by: Christian Henkel <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
… goal_id to args list Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
…xpressions Signed-off-by: Marco Lampacrescia <[email protected]>
…pe integration Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
5eaff92
to
7e1e394
Compare
def prepend_math_functions(expr: str) -> str: | ||
"""Append 'Math.' to the functions in the provided expression and return a copy.""" | ||
for fun in MATH_FUNCTIONS: | ||
expr = re.sub(rf"(^|[^a-zA-Z0-9_]){fun}\(", rf"\g<1>Math.{fun}(", expr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, I would prefer to keep the Math.
, because that's how js works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes sense. I will change this tomorrow. FYI: @m-morelli @SofiaFaraci
STATE = 0 # No callback (e.g. state entry/exit) | ||
TRANSITION = 1 # Transition callback | ||
ROS_TIMER = 2 # Timer callback | ||
ROS_TOPIC = 3 # Topic callback | ||
ROS_SERVICE_REQUEST = 4 # Service callback | ||
ROS_SERVICE_RESULT = 5 # Service callback | ||
ROS_ACTION_GOAL = 6 # Action callback | ||
ROS_ACTION_RESULT = 7 # Action callback | ||
ROS_ACTION_FEEDBACK = 8 # Action callback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STATE = 0 # No callback (e.g. state entry/exit) | |
TRANSITION = 1 # Transition callback | |
ROS_TIMER = 2 # Timer callback | |
ROS_TOPIC = 3 # Topic callback | |
ROS_SERVICE_REQUEST = 4 # Service callback | |
ROS_SERVICE_RESULT = 5 # Service callback | |
ROS_ACTION_GOAL = 6 # Action callback | |
ROS_ACTION_RESULT = 7 # Action callback | |
ROS_ACTION_FEEDBACK = 8 # Action callback | |
STATE = auto() # No callback (e.g. state entry/exit) | |
TRANSITION = auto() # Transition callback | |
ROS_TIMER = auto() # Timer callback | |
ROS_TOPIC = auto() # Topic callback | |
ROS_SERVICE_REQUEST = auto() # Service callback | |
ROS_SERVICE_RESULT = auto() # Service callback | |
ROS_ACTION_GOAL = auto() # Action callback | |
ROS_ACTION_RESULT = auto() # Action callback | |
ROS_ACTION_FEEDBACK = auto() # Action callback |
This way its more maintainable. And you need from enum import auto
.
Signed-off-by: Christian Henkel <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
…lities (#32) Signed-off-by: Marco Lampacrescia <[email protected]> Signed-off-by: Christian Henkel <[email protected]>
The main changes in this PR are: