Testing with storm #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Henkel <[email protected]>
… output Signed-off-by: Christian Henkel <[email protected]>
Signed-off-by: Christian Henkel <[email protected]>
Signed-off-by: Christian Henkel <[email protected]>
Signed-off-by: Christian Henkel <[email protected]>
MarcoLm993
reviewed
Jun 25, 2024
Signed-off-by: Christian Henkel <[email protected]>
MarcoLm993
approved these changes
Jun 25, 2024
| @@ -0,0 +1,30 @@ | |||
| { | |||
There was a problem hiding this comment.
Jani supports also listing multiple properties in the array, as long as they have different names. In smc_storm you can (and for now have to) select one to verify, based on the assigned name.
Maybe it would be easier to have only a battery_depleted_properties.jani listing all available properties, and then calling smc_storm multiple times, each time with a different property.
This way, you do not have to add another main xml file
Signed-off-by: Christian Henkel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.