Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs converting conditional transitions to jani #60

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

MarcoLm993
Copy link
Collaborator

@MarcoLm993 MarcoLm993 commented Oct 10, 2024

As title says, this PR fixes a problem when converting conditional SCXML transitions to Jani.
Additionally, a test for ensuring a correct translation of implication properties has been added (the bug itself seems to be already solved)
This addresses #37

Signed-off-by: Marco Lampacrescia <[email protected]>
Signed-off-by: Marco Lampacrescia <[email protected]>
@MarcoLm993 MarcoLm993 marked this pull request as ready for review October 10, 2024 14:31
@MarcoLm993
Copy link
Collaborator Author

MarcoLm993 commented Oct 10, 2024

Hello, I am writing this mostly for @SofiaFaraci and @m-morelli information.
This PR should solve some of the issues we noticed in Genova.
Since we switched from a multi-package to a mono-package setup, you need to remove the old packages and install the new one (conveniently called as2fm, thanks Christian for doing that 😄 ), you can find the instructions here: https://github.com/convince-project/AS2FM/pull/60/files#diff-e285c1b9901cd202e89d9f37e3249a6fee524a65428895e1a45fd062cc0f9aca

Additionally, I quickly updated the documentation with the new executable names and the new links.

Signed-off-by: Marco Lampacrescia <[email protected]>
@MarcoLm993 MarcoLm993 merged commit e92c7d4 into main Oct 11, 2024
4 checks passed
@ct2034 ct2034 deleted the bugfix-transition-conversion-to-jani-always-false branch October 11, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants