Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cache and make sure we are not fetching invalid path #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christophe-g
Copy link

@christophe-g christophe-g commented Apr 28, 2017

Just to make sure we are not fetching url when the path is not ready (e.g. "/myPath/[[resourceId]]" and resourceId is not set).

Also added a way to cache path to avoid async response when a path has already been fetched.

I did put the cache behaviors in myBehaviors namespace. This can change of course if you plan to use another namespace for this component.

@sbeleidy
Copy link
Member

Awesome @christophe-g ! Thanks for the contribution!

Will try to review it get back to you soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants