Update dependencies #1
Conversation
This commit sets the minimal requirement of Polymer to the version 1.9 (instead of the 1.4).
Before this commit the element was using dependencies themself only usable with Polymer 1. Now, the element can use dependencies using Polymer 2.
Since the element is hybrid, when it uses Polymer 2 the demo page is broken. It seems this is a known issue related to the [iron-demo-helpers](PolymerElements/iron-demo-helpers#54).
|
There's still an issue with the demo page. The demo is working but the snippet is not visible. |
|
Can you also update the version number so after merging we can push a release? |
|
Usually I prefer merge the PRs before make a new release. It avoids to create the release with a merge commit and it ensure the version number is always incremented from the master branch. All this is depending your Git strategy, so I'll follow yours. |
- make the element hybrid
|
Please tell me if I did something wrong or not following your habits. |
|
Either way works I just figured this would be easier. I assumed this would be the only thing for the next release so why not. |
|
Should we wait for the fix in the demo or just merge this so login-fire can use it? What do you think? |
|
Because the release is ready we can merge. Moreover, the issue seems known and not coming from our element. The element is pretty simple, an snippet inside the documentation would be enough for now. Of course, we have to fix it relatively quickly. NB: the priority for me is the login-fire element |
This commit sets the minimal requirement of Polymer to the version 1.9
(instead of the 1.4).