Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add custom mist #212

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: add custom mist #212

wants to merge 1 commit into from

Conversation

Morazzer
Copy link
Member

No description provided.

@Morazzer Morazzer marked this pull request as ready for review November 30, 2024 06:19
@Morazzer Morazzer self-assigned this Nov 30, 2024
GrahamKracker
GrahamKracker approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@GrahamKracker GrahamKracker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing stands out to me but i also am not really that good at reviewing

Although cycling through 15 different enums in the config might be annoying and difficult so keep that in mind?

@Morazzer
Copy link
Member Author

Looks like this doesn't work with some optimisation mods, and yeah I also don't like the cycling through all enum values

@Morazzer Morazzer marked this pull request as draft December 26, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamKracker GrahamKracker GrahamKracker approved these changes

Assignees

@Morazzer Morazzer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Morazzer @GrahamKracker