-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Party commands and melody solver #219
Merged
GrahamKracker
merged 10 commits into
cookies-mod:master
from
GrahamKracker:dungeon-notifs
Jan 22, 2025
Merged
Party commands and melody solver #219
GrahamKracker
merged 10 commits into
cookies-mod:master
from
GrahamKracker:dungeon-notifs
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morazzer
requested changes
Dec 24, 2024
src/main/java/codes/cookies/mod/features/misc/PartyCommandsFeature.java
Outdated
Show resolved
Hide resolved
src/main/java/codes/cookies/mod/features/dungeons/solver/terminals/MelodyTerminalSolver.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Moritz <[email protected]>
…ture.java Co-authored-by: Moritz <[email protected]>
Morazzer
requested changes
Dec 26, 2024
src/main/java/codes/cookies/mod/features/misc/PartyCommandsFeature.java
Outdated
Show resolved
Hide resolved
Morazzer
reviewed
Dec 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, will do some testing tomorrow and merge if I don't find any problems!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might need more testing for the melody solver part but other than that works fine :3