Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop MC 2.0 support #89

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Drop MC 2.0 support #89

merged 2 commits into from
Mar 29, 2024

Conversation

pi8027
Copy link
Contributor

@pi8027 pi8027 commented Mar 29, 2024 •
edited
Loading

No description provided.

@pi8027
Copy link
Contributor Author

pi8027 commented Mar 29, 2024 •
edited
Loading

@proux01 It seems that the renaming from finIntegralDomainType to finIdomainType happened in MC 2.1 (with no CHANGELOG entry ?). I restored the deprecation notation in math-comp/math-comp#1190, but we can turn this PR into one dropping the support for MC 2.0.

@proux01
Copy link
Collaborator

proux01 commented Mar 29, 2024

Well, it's rather that, as the deprecation message tells, the deprecation was forgotten in 2.0.0 (considering the amount of change it's in fact impressive that we didn't forgot more things).
Anyway, we'll have to drop support for MC 2.0 at some point here, let's just do it now.

@pi8027 pi8027 changed the title Adapt to math-comp/math-comp#1190 Drop MC 2.0 support Mar 29, 2024
@proux01 proux01 merged commit 73f9ec4 into master Mar 29, 2024
13 checks passed
@proux01 proux01 deleted the mc_1190 branch March 29, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pi8027 @proux01