Compatible with Coq 8.20 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tested this locally. I'm letting CI do it. |
4 tasks
|
@pi8027 is breakage for Coq 8.20 due to a recent change in Coq? I can see that CI passed for the |
|
@palmskog It seems that coq/coq#18590 broke graph-theory. |
|
I observed the breakage here: math-comp/math-comp#1166 https://github.com/math-comp/math-comp/actions/runs/8357816001/job/22879083232?pr=1166 |
|
@pi8027 OK, but then maybe we should just drop 8.17 support directly? Or what is the plan for MathComp generally? I guess I go with whatever most MathComp projects do. |
|
I don't know "what most MathComp projects do" but MathComp itself already dropped 8.17 support. |
pi8027
force-pushed
the
coq-8.20
branch
2 times, most recently
from
ed7ae39
to
0757a35
Compare
|
Done. |
pi8027
commented
Mar 20, 2024
|
Thanks, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.