Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial Equations: well-founded recursion #8

Merged
merged 37 commits into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
770b2cc
draft tuto Equations wf
thomas-lamiaux May 14, 2024
df65498
some work
thomas-lamiaux May 14, 2024
8eba324
Merge branch 'tuto-equations-wf' of github.com:Zimmi48/platform-docs …
thomas-lamiaux May 15, 2024
2a530ec
implement new contribution guidelines
thomas-lamiaux May 15, 2024
597b43c
edit Contribting >> talk about issues
thomas-lamiaux May 17, 2024
39fad41
edits contrib + readme
thomas-lamiaux May 17, 2024
2fca3ef
Update README.md
thomas-lamiaux May 17, 2024
13ef8ab
Update CONTRIBUTING.md
thomas-lamiaux May 17, 2024
5ffb2f4
fix ack
thomas-lamiaux May 18, 2024
af42cec
fix file
thomas-lamiaux May 18, 2024
dd94445
moved to_fill
thomas-lamiaux May 18, 2024
11965de
Fix typos from code review
thomas-lamiaux May 28, 2024
162bf2f
add file on obligations
thomas-lamiaux Jun 9, 2024
09640bc
typos
thomas-lamiaux Jun 9, 2024
f540689
edits obligations
thomas-lamiaux Jun 9, 2024
f7df1fc
Major refactoring of tuto wf:
thomas-lamiaux Jun 9, 2024
f63b2e4
work on 2.1 2.2 2.3
thomas-lamiaux Jun 9, 2024
c51538c
Apply suggestions from code review
thomas-lamiaux Jun 10, 2024
5e87263
typos
thomas-lamiaux Jun 10, 2024
4f7377f
Merge branch 'tuto-equations-wf' of github.com:Zimmi48/platform-docs …
thomas-lamiaux Jun 10, 2024
6c6b586
add example linear search
thomas-lamiaux Jun 10, 2024
6554b53
some work
thomas-lamiaux Jun 11, 2024
c2dbc80
added comments printing obligations
thomas-lamiaux Jun 11, 2024
7fa2b64
edits 2.2
thomas-lamiaux Jun 11, 2024
01761ff
content section 2.2
thomas-lamiaux Jun 12, 2024
4fa0bcf
removed section 2.2 by lack of example
thomas-lamiaux Jun 12, 2024
c70a734
typos
thomas-lamiaux Jun 12, 2024
07b975f
more typos
thomas-lamiaux Jun 12, 2024
1ef2a48
work 1.2
thomas-lamiaux Jun 12, 2024
59f92a5
clean up
thomas-lamiaux Jun 12, 2024
1d0bb32
clean up
thomas-lamiaux Jun 12, 2024
3159008
Apply suggestions from code review
thomas-lamiaux Jun 19, 2024
f9ee8e2
Update src/Tutorial_Equations_wf.v
thomas-lamiaux Jun 19, 2024
0f0c509
Merge branch 'main' into tuto-equations-wf
thomas-lamiaux Jun 19, 2024
169591a
edits custom wf
thomas-lamiaux Jun 20, 2024
ca5047b
Update Tutorial_Equations_wf.v
thomas-lamiaux Jun 21, 2024
beac686
Update Tutorial_Equations_wf.v
thomas-lamiaux Jun 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 33 additions & 10 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ There are different possible ways to contribute depending on your time and techn
- There is technical work to be done on the (interactive) web interface side


> [!TIP]
> Before starting to work on something and invest time into it, check if it is not already existing,
> or if someone hasn't already started working on it, either by creating a discussion on the [Zulip stream](https://coq.zulipchat.com/#narrow/stream/437203-Platform-docs) or a draft pull request about it.

### Writing Tutorials and How-tos
If you have an idea for a tutorial or how-to, you can create a discussion on the dedicated [Zulip stream](https://coq.zulipchat.com/#narrow/stream/437203-Platform-docs)
to get feedback on your idea, through the writing and to reach others that may be interested.
Expand All @@ -23,10 +27,6 @@ Equation, you can create a discussion in the associated stream.
Once you have a plan and some content, you can create a draft pull request to make your code accessible
and get feedback on it while you (and others) progress on it.

> [!WARNING]
> Before starting to work on a tutorial or a how-to and invest time into it, check if it is not already existing,
> or if someone hasn't already started working on it, either by creating a discussion on the [Zulip stream](https://coq.zulipchat.com/#narrow/stream/437203-Platform-docs) or a draft pull request about it.

> [!WARNING]
> Lots of stuff have already be written about Coq, it can make sense to reuse some of the content.
> If you wish to do so, be careful that you are indeed allowed by the copyright owners or the content licenses.
Expand Down Expand Up @@ -82,7 +82,7 @@ As examples, we have been working on new tutorials for the package Equations.
The first one is complete and can be checked out [here](src/Tutorial_Equations_basics.v).


### Horizontality
### Writing Horizontal Tutorials

Tutorials do not necessarily need to be long, nor should aim to present
all the aspects of a feature in one unique tutorial.
Expand All @@ -104,8 +104,33 @@ Doing so only takes a bit more time when writing a tutorial but saves a lot of t
that will not have to chase information in different other tutorials, tutorials which could in turn refer to other tutorials.
It also eases maintenance as one does not need to worry about potential modifications to other tutorials.

### Discussing Recurring Issues

When writing a tutorial, it often happens to be confronted to something that
does not work as easily as expected due to limitations of a feature or genuine bugs.
In this case, often people decide not to mention the problem as they plan /
it is planned to fix the problem.
The issue is that most times, it turns out that it is actually not that easy to fix
nor that fast, and meanwhile users are left with a solution.
Worse, not only they are not told how to go around the problem,
but they are not even warned that a problem may rise up.
This can be particularly limiting for non expert users, that may not be able
to identify the problem and manage to go around it on their own.

This issue is particularly relevant in our case, as the documentation is aimed
at the general public, and is indexed on the versions of Coq platform
that do not change everyday.

> [!NOTE]
> Consequently, it is really important to mention in tutorials issues that
> often come up with a feature, and to provide as reasonable solution as possible.
> The tutorials can always be modified once the fix are effective, but meanwhile
> users have solutions.


### Adding Exercises
As tutorials are meant for studying, do not hesitate to add some exercises for the users to try, e.g. functions or properties to prove or finish.
As tutorials are meant for studying, do not hesitate to add some exercises
for the users to try, e.g. functions or properties to prove or finish.
In general, we recommend to provide at least definitions prefilled with typing information like:

```
Expand All @@ -115,13 +140,11 @@ Lemma map_app {A B} (f : A -> B) (l l' : list A) : map f (l ++ l') = map f l + m
Proof. Admitted.
```

To do so, you can add the following code at the beginning of the tutorial.
It creates an axiom `to_fill` and hides it so that it is does not appear in the body of the tutorial.
To do so, you can add the following code at the beginning of the tutorial,
that creates an axiom that can fill any goal.
```
(* begin hide *)
Axiom to_fill : forall A, A.
Arguments to_fill {_}.
(* end hide *)
```

You can also provides tests for the users to be able to check if their definition works.
Expand Down
10 changes: 8 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,14 @@ of tutorials and how-tos it could be interesting to have.
This list is not fixed and will necessarily evolve through discussions with the community and experience,
but it should already give an idea of the potential of this project.

The project can already been discussed on the dedicated [Zulip stream](https://coq.zulipchat.com/#narrow/stream/437203-Platform-docs).
We will also soon submit a Coq Enhancement Proposal.

> [!NOTE]
> For more information about project and to participate in disccusions, please checkout on the dedicated [Zulip stream](https://coq.zulipchat.com/#narrow/stream/437203-Platform-docs).
> Among others, you can find there information about [new tutorials and how-tos](https://coq.zulipchat.com/#narrow/stream/437203-Coq-Platform-docs/topic/New.20Tutorials.20and.20How-to.20to.20check.20out), and a [wishlist](https://coq.zulipchat.com/#narrow/stream/437203-Coq-Platform-docs/topic/Wishlist.20Tutorials) to tell us what you need





### How to contribute to the documentation
Expand All @@ -91,7 +96,8 @@ There are different possible ways to contribute depending on your time and techn
- There is a lot of tutorials and how-tos to write, both about Coq and plugins in its Platform
- There is technical work to be done on the (interactive) web interface side

For more information on how to contribute, please check the [Contribution Guidelines](CONTRIBUTING.md).
> [!IMPORTANT]
> For more information on how to contribute, please check the [Contribution Guidelines](CONTRIBUTING.md).



278 changes: 278 additions & 0 deletions src/Tutorial_Equations_Obligations.v
Original file line number Diff line number Diff line change
@@ -0,0 +1,278 @@
(** * Equations and Obligations

*** Summary

[Equations] is a plugin for %\cite{Coq}% that offers a powerful support
for writing functions by dependent pattern matching.
In this tutorial, we discuss how it interface with [Program] to help write
programs using obligations.

In section 1, we recall the concept of obligation and how they interface with [Equations].
In Section 2, we discuss [Equations]' obligation solving tactic.


*** Table of content

- 1. Equations and Obligations
- 1.1 Obligations
- 1.2 Solving obligations
- 2. Equations' solving tactic
- 2.1 Personalizing the tactic proving obligations
- 2.2 What to do if goals are oversimplified


*** Prerequisites

Needed:
- We assume basic knowledge of Coq, and of defining functions by recursion
- We assume basic knowledge of the Equations plugin, e.g, as presented
in the tutorial Equations: Basics

Not needed:

Installation:
- Equations is available by default in the Coq Platform
- Otherwise, it is available via opam under the name coq-equations

*)


From Coq Require Import List.
Import ListNotations.

From Equations Require Import Equations.

Axiom to_fill : forall A, A.
Arguments to_fill {_}.


(** ** 1. Equations and Obligations

*** 1.1 Obligations

In some cases, to define functions we may have to prove properties.
There can be many reasons for that. Among others, the data structure under
consideration may can include invariants that we must prove to be preserved
when defining functions.

For instance, vectors of size [n] can be defined as lists of length [n],
that is, as a list [l] with a proof that [length l = n].
*)

Definition vec A n := { l : list A | length l = n }.

(** To define a function [vec A n -> vec A m], one has to explain how the
function acts on lists, and to prove that the resulting list is of size
[m] providing the original one is of size [n].

For instance, to define a concatenation function on vectors
[vapp : vec A n -> vec A m -> vec A (n + m)], as done below, one has to:
- specify that the concatenation of [l] and [l'] is [app l l'] and,
- provide a proof term that [length (ln ++ lm) = n + m], which is done
below by the term [eq_trans (app_length ln lm) (f_equal2 Nat.add Hn Hm)].
*)

Equations vapp {A n m} (v1 : vec A n) (v2 : vec A m) : vec A (n + m) :=
vapp (exist _ ln Hn) (exist _ lm Hm) :=
(exist _ (app ln lm)
(eq_trans (app_length ln lm) (f_equal2 Nat.add Hn Hm))).

(** Yet, in most cases, when defining a function, we do not want to write down
the proofs directly as terms, as we did above.
There are many reasons for that:
- in practice, proof terms can be arbitrarily large and complex making it
tedious if not impossible to write them down directly as terms
- even if we could, this can easily make the function completely illegible
- in case of changes, it is not possible to replay a term proof as we can
replay a tactic script in order to adapt it, making functions harder
to adapt

Therefore, we would much rather like to build our terms using the proof mode.
This is exactly what [Program] and obligations enables us to do.
At every point in a definition, it allows us to write down a wildcard [_]
instead of a term, it will then:
- 1. create an obligation, intuitively a goal left to solve
to complete the definition
- 2. try to simplify the obligations and solve them using a tactic,
in our case, using a tactic specific to [Equations]
- 3. if there are any obligations left to solve, enable us to prove them using
the proof mode and tactics using [Next Obligation] or [Equations?] that
we discuss in section 1.2


For instance, we can define a function [vapp n m : vec A n -> vec A m -> vec A (n+m)]
using a wildcard [_] where a proof of [length (app ln lm) = n + m]
is expected to prove it using tactics:
*)

Equations vapp' {A n m} (v1 : vec A n) (v2 : vec A m) : vec A (n + m) :=
vapp' (exist _ ln Hn) (exist _ lm Hm) := exist _ (app ln lm) _.
Next Obligation.
apply app_length.
Qed.

(** As you can see, this is very practical, however, you should be aware of
three basic pitfalls:

1. As you may have noticed the goal to prove was not [length (app ln lm) = n + m]
as expected, but [length (app ln lm) = length ln + length lm].
This is because [Equations]' custom solving tactic has already pre-simplified
the goal for us. In can be an issue in some cases, and we discuss it in
section 2.2.

2. Technically, you can use a wildcard [_] for any term, even for one that
is relevant (i.e. not a proof) to the definition and computation like [app ln lm].
Yet, it is generally a bad idea as automation could then infer
something random that by concidence happens to match the expected type.

3. Be aware that a definition is not defined until all its associated
obligations have been solved. Trying to refer to it before that, we
consequently trigger the error that the defintion was not found.
For instance, consider the unfinished definition of [vmap] with a wildcar [_]
thomas-lamiaux marked this conversation as resolved.
Show resolved Hide resolved
*)

Equations vmap {A B n} (f : A -> B) (v : vec A n) : vec B n :=
vmap f (exist _ ln Hn) := exist _ (map f ln) _ .

Fail Definition vmap_comp {A B C n} (g : B -> C) (f : A -> B) (v : vec A n)
: vmap g (vmap f n v) = vmap (fun x => g (f x)) v.

(** Obligations are not well displayed by all IDE. If it the case, you can always
print them using [Obligations of name_obligations].
For instance, for [vmap]:
*)
Obligations of vmap_obligations.


(** *** 1.2 Solving obligations

There are two different methods to solve the remaining obligations.

You can solve the obligations one by one using the command [Next Obligations].
Doing so for [vmap] display the goal [length (map f ln) = length ln],
which we can then solve using tactics.
*)

Next Obligation.
apply map_length.
Qed.

(** Using [Next Obligation] has the advantage that once an obligation has been
solved, [Program] retries automatically to prove the remaining obligations.
It can be practical when proofs are simple but requires for a variable
to be solved first to be able to proceed.

Note, that it can be useful to add [Fail Next Obligation] once all
obligations have been solved.
This way, if a change somewhere now leaves an obligation unsolved, we can
easily track down the issue to the culprit definition.

Alternatively, it is possible to use the keyword [Equations?] to automatically
unshelve all obligations, that is enter the proof mode and create a goal
for each of the obligations remaining.

For an example, we can redefine [vmap] using it:
*)

Equations? vmap' {A B n} (f : A -> B) (v : vec A n) : vec B n :=
vmap' f (exist _ ln Hn) := exist _ (map f ln) _ .
Proof.
apply map_length.
Defined.

(** Though, note that [Equations?] triggers a warning when used on a definition
that leaves no obligations unsolved.
It is because for technical reasons, [Equations?] cannot check if there
is at least one obligation left to solve before opening the proof mode.
Hence, when there is no obligation proof mode is opened for nothing, and
has to be closed by hand using [Qed] (for proof irrelevant content) as it can be seen below.
As it is easy to forget, a warning is raised.
*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another difference is that with Equations, you can control which generated obligations are opaque or transparent, by closing them with either Qed or Defined. Afaik, for Equations? no such fine-grained control is available? But again it might be "advanced" trickery that you might not want in a tutorial for beginners.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually thinking about that. I have no idea of the behavior we get. I'll talk to Mathieu about that tomorrow

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I have asked and it does enable a better control, btw that is one of the advantage of Next obligation compared to Equation?, but I would rather not talk about it as it is really advanced.


Equations? vnil {A} : vec A 0 :=
vnil := exist _ nil eq_refl.
Defined.


(** ** 2. Equations' solving tactic

As mentioned, [Equations] automatically tries to solve obligations.
It does so using a custom strategy basically simplifying the goals and
running a solver.
It can be viewed with the following command:
*)

Show Obligation Tactic.

(** 2.1 Personalizing the tactic proving obligations

When working, it is common to be dealing with a particular class of
functions that shares a common theory, e.g, they involve basic arithmetic.
This theory cannot not be guessed by the basic automation tactic,
so one may want a personalized tactic to handle a particular theory.

This can be done using the command [ #[local] Obligation Tactic := tac ]
that locally changes the tactic solving obligation to [tac].

For example, consider a [gcd] function defined by well-founded recursion.
There are two obligations left to prove corresponding to proofs that the recursive
call are indeed performed on smaller instance.
Each of them corresponds to basic reasoning about arithmetics, and can
be solved with the solver [lia].
*)

Require Import Arith Lia.

Equations? gcd (x y : nat) : nat by wf (x + y) lt :=
gcd 0 x := x ;
gcd x 0 := x ;
gcd x y with gt_eq_gt_dec x y := {
| inleft (left _) := gcd x (y - x) ;
| inleft (right refl) := x ;
| inright _ := gcd (x - y) y }.
Proof.
lia. lia.
Abort.

(** Therefore, we would like to locally change the tactic solving the
obligations to take into account arithmetic, and try the [lia] tactic.
We do so by simply trying it after the current solving tactic,
i.e. the one displayed by [Show Obligation Tactic].
As we can see by running again [Show Obligation Tactic], it has indeed been
added, and [gcd] is now accepted directly.
*)

#[local] Obligation Tactic :=
simpl in *;
Tactics.program_simplify;
CoreTactics.equations_simpl;
try Tactics.program_solve_wf;
try lia.

Show Obligation Tactic.

Equations gcd (x y : nat) : nat by wf (x + y) lt :=
gcd 0 x := x ;
gcd x 0 := x ;
gcd x y with gt_eq_gt_dec x y := {
| inleft (left _) := gcd x (y - x) ;
| inleft (right refl) := x ;
| inright _ := gcd (x - y) y
}.

(** 2.2 What to do if goals are oversimplified

In some cases, it can happen that [Equations]' solving tactic is too abrut
and oversimplies goals, or mis-specialised and ends up getting us stuck.
The automation can also become slow, and one might want to diagnose this.
In any of these cases, it can be useful to set the solving tactic locally to the identity.
That way, the obligations one gets is the raw ones generated by [Equations]
without preprocessing, which can then be "manually" explored.

In this case, a useful trick is to use an attribute to set the obligation
tactic to [idtac] only for the definition at hand, using the scheme
[ #[tactic="idtac"] Equations? name ...].

Unfortunately, at the moment we do not have a simple enough minimal working
example. If you have one, do not hesitate to create a PR.
*)
Loading