Block on parse error #1002
Open
Block on parse error #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of ignoring parse errors, we make the ast a sentence_state object which either contains the parse_error or the parsed_ast. This will allow to detect parsing errors and block on the error instead of checking through it.
gares
reviewed
Jan 21, 2025
language-server/dm/document.ml
Outdated
| log @@ "handling parse error at " ^ string_of_int start; | ||
| let stop = Stream.count stream in | ||
| let parsing_error = { msg; start; stop; qf} in | ||
| let synterp_state = Vernacstate.Synterp.freeze () in |
There was a problem hiding this comment.
I think you should just pass the synterp state you used to parser the sentence, rather than freezing it here.
I think in practice it will be the same, but there is no need to recompute the snapshot.
We create a Block type in the scheduler (and its corresponding PBlock in execution manager) which will send an exec_error if one tries to execute through a parse error. If the user has set block_on_error mode then the behaviour is now identical with parsing errors and execution errors.
rtetley
force-pushed
the
block-on-parse-error
branch
from
61f4d97 to
e4016bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the mechanism for parse errors are different than exec errors.
This is a limitation as we cannot block on the first parse error.
We introduce a mechanism to record a sentence state allowing us to detect that a sentence has a parse error and prevent from executing it.
Closes #877