dte: Allow gaps when validating order of DteXmlData.referencias
#583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relax validation of ordering of `DteXmlData.referencias` by `numero_linea_ref` by allowing ordered sequences of `referencias` to have gaps. Ref: https://app.shortcut.com/cordada/story/3733 [sc-3733]
|
This pull request has been linked to Shortcut Story #3733: Allow gaps in número línea refs. when validating order of DteXmlData.referencias. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #583 +/- ##
========================================
Coverage 86.98% 86.98%
========================================
Files 34 34
Lines 3013 3013
Branches 378 378
========================================
Hits 2621 2621
Misses 250 250
Partials 142 142 ☔ View full report in Codecov by Sentry. |
svillegas-cdd
approved these changes
Jan 10, 2024
jtrobles-cdd
deleted the
task/relax-validation-dte-xml-num-linea-ref-order
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax validation of ordering of
DteXmlData.referenciasbynumero_linea_refby allowing ordered sequences ofreferenciasto have gaps.Ref: https://app.shortcut.com/cordada/story/3733 [sc-3733]
Related: #557