fix: Add default value for missing code 098 in SII CTE Form 29
#586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add code `098` to file used by schema validator :func:`cte_f29_datos_schema_best_effort_validator`, since this code is currently missing in the `tipos` and `glosa` sections of the F29 file. - Fixed exception message when the keys of `campos` and `glosa` are different Ref: https://app.shortcut.com/cordada/story/3852/ Ref: [FD-CL-DATA-230](https://fynpal-com.sentry.io/issues/4907498672/)
|
This pull request has been linked to Shortcut Story #3852: Errors creating CteForm29. |
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #586 +/- ##
========================================
Coverage 86.98% 86.98%
========================================
Files 34 34
Lines 3013 3013
Branches 378 378
========================================
Hits 2621 2621
Misses 250 250
Partials 142 142 ☔ View full report in Codecov by Sentry. |
fpinto-cdd
approved these changes
Jan 24, 2024
|
@jtrobles-cdd The error is due to codecov as I edited the error message in |
jtrobles-cdd
approved these changes
Jan 30, 2024
I'll force the merge to bypass the GitHub check. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code
098to file used by schema validator:func:
cte_f29_datos_schema_best_effort_validator, since this code is currently missing in thetiposandglosasections of the F29 file.Fixed exception message when the keys of
camposandglosaare differentRef: https://app.shortcut.com/cordada/story/3852/
Ref: FD-CL-DATA-230
Fixes: FD-CL-DATA-230