Annotate method return types with typing.Self where appropriate
#759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jtrobles-cdd
commented
Jan 27, 2025
jtrobles-cdd
commented
> The `typing_extensions` module serves two related purposes: > > - Enable use of new type system features on older Python versions. […] > - Enable experimentation with new type system PEPs before they are > accepted and added to the `typing` module. - [Web Site](https://github.com/python/typing_extensions) - [VCS Repository](https://github.com/python/typing_extensions.git) - [Documentation](https://typing-extensions.readthedocs.io/) - [Software Repository](https://pypi.org/project/typing-extensions/)
> In general, if something returns `self`, […], you should use `Self` as > the return annotation. > You should not use `Self` as the return annotation if the method is > not guaranteed to return an instance of a subclass when the class is > subclassed […]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #759 +/- ##
===========================================
+ Coverage 87.72% 87.74% +0.01%
===========================================
Files 38 38
Lines 3145 3149 +4
Branches 385 385
===========================================
+ Hits 2759 2763 +4
Misses 245 245
Partials 141 141 ☔ View full report in Codecov by Sentry. |
fpinto-cdd
approved these changes
Jan 28, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.