Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay/sysusers: remove 10-groups-basic.conf which comes from setup package #2539

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

HuijingHei
Copy link
Member

As setup shipped its own sysusers.d entries,
see https://src.fedoraproject.org/rpms/setup/c/ff8169d809a5de20864deb6bb41c4b4104a3fb61?branch=f38 and https://src.fedoraproject.org/rpms/setup/c/9174b59bde57a991c284c10dac749d061f93aaad?branch=f38, we should remove the duplicated entries in 10-groups-basic.conf.

Xerf to #1836

@travier
Copy link
Member

travier commented Aug 16, 2023

I've compared /usr/lib/sysusers.d/20-setup-users.conf, /usr/lib/sysusers.d/20-setup-groups.conf and https://github.com/coreos/fedora-coreos-config/blob/testing-devel/overlay.d/15fcos/usr/lib/sysusers.d/10-setup-basic.conf on a live system and the content mostly matches excepted for the games group case which links to systemd/systemd#24217 which should be fixed now.

@HuijingHei
Copy link
Member Author

Thanks @travier for the checking, and nobody mismatched issue is tracked by coreos/fedora-coreos-tracker#1201

@cgwalters
Copy link
Member

Oh wow, I didn't realize we had another copy of that data! Nice work to delete it!

@cgwalters
Copy link
Member

OK now here's the tricky thing though...this content also gets pulled into openshift/os pretty quickly in the development stream, so anything that lands here generally will need to work on RHEL 9.2 as well.

So the basic question is did systemd/systemd#24249 make it into RHEL 9.2 yet?

@cgwalters
Copy link
Member

(If it didn't, we can still land this PR here, but re-add the file in openshift/os)

@HuijingHei
Copy link
Member Author

HuijingHei commented Aug 16, 2023

this content also gets pulled into openshift/os pretty quickly in the development stream

The overlay sysuser config files are under dir 15fcos, that will not included in openshift/os xref to https://github.com/openshift/os/tree/master/overlay.d, so this is safe for RHCOS.

did systemd/systemd#24249 make it into RHEL 9.2 yet?

Not yet, and sysusers configuration fragment for setup is also not included in RHEL 9.2 (setup-2.13.7-9.el9), maybe both will be added in future.

@travier
Copy link
Member

travier commented Aug 16, 2023

Thanks @travier for the checking, and nobody mismatched issue is tracked by coreos/fedora-coreos-tracker#1201

The "legacy" nobody group is enforced by: https://github.com/coreos/fedora-coreos-config/blob/testing-devel/overlay.d/15fcos/usr/lib/sysusers.d/00-coreos-nobody.conf

@HuijingHei HuijingHei merged commit 400faad into coreos:testing-devel Aug 17, 2023
@HuijingHei HuijingHei deleted the deduplicate-group branch August 17, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants