Azure: add Launch a confidential VM part
#671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuijingHei
force-pushed
the
azure-confidential-vm
branch
2 times, most recently
from
e0cd4d5
to
eb21d42
Compare
|
I want to review this thoroughly and I'm out of time right now. One note off hand is that maybe we should consider modifying the instructions at the top under If I understand correctly the image we create there can work for confidential VM or not confidential VM. Also I think we'll have to use a compute gallery if we ever want these instructions to work for aarch64? |
HuijingHei
force-pushed
the
azure-confidential-vm
branch
from
eb21d42
to
71be0c1
Compare
Yes, I think so. If I remember correctly, we do not have confidential VM auto test on Azure, maybe we should add it. |
HuijingHei
force-pushed
the
azure-confidential-vm
branch
from
71be0c1
to
b0baed2
Compare
HuijingHei
force-pushed
the
azure-confidential-vm
branch
from
b0baed2
to
affbd84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.