Resolve FPs reported under issue 6 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseion
requested changes
Sep 23, 2023
Co-authored-by: Max Leske <[email protected]>
Co-authored-by: Max Leske <[email protected]>
theseion
approved these changes
Sep 23, 2023
|
Considering that @AlroneRhyn has not responded in weeks and is unlikely to respond to this PR now I'll merge this. |
|
fair enough, I'll open another PR if he does report any issues or if I discover issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
I also fixed a few additional FP I noticed while working on this issue