-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: false positive related to navigation menu update #47
Conversation
@azurit You've missed the other false positive op reported for |
@EsadCetiner Hm, what about to join rules 9507146 and 9507140 into one? |
@azurit Normally I would, but in this case the restricted headers has to be kept in sync with |
Ok, that makes sense. |
@EsadCetiner Ready to merge? |
@azurit Are you going to rewrite 9507146 like how I suggested to reduce the maintenance of that rule, or do you have a better idea? SecRule REQUEST_FILENAME "@rx /wp-json/wp/v[0-9]+/(?:posts|pages|users|templates|navigation)" \
"id:9507146,\
phase:1,\
pass,\
t:none,\
nolog,\
ver:'wordpress-rule-exclusions-plugin/1.0.1',\
chain"
- SecRule REQUEST_METHOD "@streq POST" \
+ SecRule &REQUEST_HEADERS:x-http-method-override "!@eq 0" \
"t:none,\
- setvar:'tx.restricted_headers_basic=/content-encoding/ /proxy/ /lock-token/ /content-range/ /if/ /x-http-method/ /x-method-override/'"
+ ctl:ruleRemoveById=920450" |
I misunderstood you, done. |
Fixes #46.