-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fp when editing template-parts in gutenberg editor #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you 'fix' tests?
Thanks. |
Thanks, I missed that, cleaned up the tests a bit too. |
azurit
reviewed
Jun 28, 2024
Co-authored-by: azurit <[email protected]>
azurit
reviewed
Jun 28, 2024
azurit
reviewed
Jun 28, 2024
azurit
reviewed
Jun 28, 2024
Co-authored-by: azurit <[email protected]>
@EsadCetiner Why have you decided to remove |
@azurit It caused a false positive, 9507600 is meant to apply unconditionally but it only apples for wp-admin because of the skip rule. |
Then i suggest to move 9507600 out of that block (and renumber it if you feel it's needed). |
azurit
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes false positives with the new gutenberg when editing template parts of a website, for instance the header or footer.
I couldn't figure out why the linter is failing, I can't find any trailing whitespace, missing/extra line breaks, and the error message is ambiguous.nvm I can see the error now after I've opened the PR.