kernel bitwise_or #158
Open
kernel bitwise_or #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yodada
reviewed
Oct 12, 2020
| Tensor or_kernel_hb(const Tensor& self, const Tensor& other) { | ||
| TORCH_CHECK(self.numel() == other.numel(), "The size of two tensors should match."); | ||
| // TORCH_CHECK(self.scalar_type() == ScalarType::Int || self.scalar_type() == ScalarType::Bool, "HammerBlade or is implemented for Int and Bool only"); | ||
| // TORCH_CHECK(other.scalar_type() == ScalarType::Int || other.scalar_type() == ScalarType::Bool, "HammerBlade or is implemented for Int and Bool only"); |
There was a problem hiding this comment.
Same as and, I think if you do self.scalar_type() == kInt it will work
Maybe you need at::kInt ...
yodada
reviewed
Oct 12, 2020
| hb_tensor_t* t0_p, | ||
| hb_tensor_t* t1_p, | ||
| hb_tensor_t* t2_p) { | ||
| auto res = HBTensor<int>(t0_p); |
There was a problem hiding this comment.
Similar to and, we need to handle booleans and test for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitwise_or with two tensor inputs, supports int and bool types