Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: make review summary gauge card responsive #486

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

Destaq
Copy link
Member

@Destaq Destaq commented Dec 10, 2024

Summary

Helps mobile & tablet users of CUReviews go from 😠 to 👌 when looking at the ratings page for a course! Thanks to this PR, the summary card at the top of said ratings page is now responsive.

PR Type

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Mobile + Desktop Screenshots & Recordings

cureviews-style-fix.mp4

QA - Test Plan

Drag around the window size & confirm that the summary / review info card is responsive / fully visible under 1216px (compare with the live version of CUReviews).

Breaking Changes & Notes

Zip

Added to documentation?

  • 📜 README.md
  • 📓 notion
  • 🍕 ...
  • 📕 ...
  • 🙅 no documentation needed

What GIF represents this PR?

gif

@Destaq Destaq requested a review from a team as a code owner December 10, 2024 00:18
@CLAassistant
Copy link

CLAassistant commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

@dti-github-bot
Copy link
Member

dti-github-bot commented Dec 10, 2024

[diff-counting] Significant lines: 27.

@cornell-dti cornell-dti deleted a comment from CLAassistant Dec 10, 2024
Copy link
Contributor

@qiandrewj qiandrewj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon 😆 Looks a lot better now on mobile views especially, getting rid of the hidden overflow problem we were having. I've been educated in design and CSS 🙌

@qiandrewj qiandrewj merged commit b00b42d into main Dec 10, 2024
4 checks passed
@qiandrewj qiandrewj deleted the responsive-review-summary-card branch December 10, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants