Improve Similarity Results #490
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 47. |
qiandrewj
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Jacqueline - going through the tested courses, it's really great that now crosslisted classes won't be repeated, which was one of the most obvious problems I noticed. As for description processing, I still think there may be some words we can eliminate -- from the one test, things I'm immediately seeing are it, you, not, but, have, been, of, all, in, your, their, do, this, a, is -- might make our recommendations more relevant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR works on the Similar Courses feature.
PR Type
Mobile + Desktop Screenshots & Recordings
Top 2 similar courses for OS:
QA - Test Plan
http://localhost:8080/api/search/get-courses- search up any of the following classes: engl 1147, iard 6970, hist 1941, engl 6553, cs 4410, coml 4704, russl 3341For processed descriptions:
http://localhost:8080/api/courses/get-rec-metadatabody:
{ "number": "1609", "subject": "pe" }Breaking Changes & Notes
Added to documentation?
What GIF represents this PR?
gif