Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertical height of profile dropdown #497

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Conversation

mjaydenkim
Copy link
Contributor

@mjaydenkim mjaydenkim commented Dec 26, 2024

Summary

this PR fixes the vertical length of the top-right profile dropdown!! (yet another one liner)

PR Type

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Mobile + Desktop Screenshots & Recordings

image

QA - Test Plan

Tested on a variety of sizes/zooms.

Breaking Changes & Notes

this also seems like a fix that might be too simple, but it appears to work after simple testing

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ notion
  • πŸ• ...
  • πŸ“• ...
  • πŸ™… no documentation needed

What GIF represents this PR?

gif

@mjaydenkim mjaydenkim requested a review from a team as a code owner December 26, 2024 22:27
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 1.

Copy link
Contributor

@qiandrewj qiandrewj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mjaydenkim mjaydenkim merged commit 9f6e1af into main Dec 26, 2024
4 checks passed
@mjaydenkim mjaydenkim deleted the matt/profile-navbar-length branch December 26, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants